New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLIP: Merge Products.RedirectionTool into core #1486

Open
vangheem opened this Issue Mar 24, 2016 · 23 comments

Comments

@vangheem
Member

vangheem commented Mar 24, 2016

Proposer : vangheem

Seconder : ?

Abstract

Allow users to manage redirects on their site and aliases to content.

Motivation

Managing aliases and redirects on your site is a very important feature that should be handled OOTB.

Assumptions

Proposal & Implementation

  • merge Products.RedirectionTool into Products.CMFPlone
  • improve control panel view to allow for paging(sites with many redirects make this page unusable otherwise)
  • move the top-level toolbar entry to the "Actions" menu.

Deliverables

  • a PR with the feature merged into Products.CMFPlone

Risks

  • Current use of the word "Alias" in redirection tool is confusing.
  • Current redirectiontool doesn't warn when previous redirections have been replaced by other content and will no longer work
  • Current toplevel toolbar item adds extra noise to the toolbar.
@djay

This comment has been minimized.

Show comment
Hide comment
@djay

djay Mar 25, 2016

Member

yes please. I added a risk about "Current use of the word "Alias" in redirection tool is confusing". Most of my users when asking for this talk about creating short urls, extra urls, alternative urls for content.

Also I suspect the UI for this could be combined with the UI for adjusting the shortname. Currently the UI for changing the short-name is buried in rename, which is also not that intuitive. It makes sense if you get the folder metaphor, but people coming at CMS from a public website point of view are thinking of adjusting their urls.

Member

djay commented Mar 25, 2016

yes please. I added a risk about "Current use of the word "Alias" in redirection tool is confusing". Most of my users when asking for this talk about creating short urls, extra urls, alternative urls for content.

Also I suspect the UI for this could be combined with the UI for adjusting the shortname. Currently the UI for changing the short-name is buried in rename, which is also not that intuitive. It makes sense if you get the folder metaphor, but people coming at CMS from a public website point of view are thinking of adjusting their urls.

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Mar 25, 2016

Contributor

An extra bonus for me would be to be able to create external redirects from within the control panel, so this way our marketing team could handle that from a central place. Right now, although external URLs are supported, they can not be created TTW.

Contributor

gforcada commented Mar 25, 2016

An extra bonus for me would be to be able to create external redirects from within the control panel, so this way our marketing team could handle that from a central place. Right now, although external URLs are supported, they can not be created TTW.

@datakurre

This comment has been minimized.

Show comment
Hide comment
@datakurre

datakurre Apr 4, 2016

Member

👍 and 👍 for @gforcada's addition

Member

datakurre commented Apr 4, 2016

👍 and 👍 for @gforcada's addition

@ebrehault

This comment has been minimized.

Show comment
Hide comment
@ebrehault

ebrehault Apr 8, 2016

Member

I think "Current toplevel toolbar item adds extra noise to the toolbar" should not be listed as a risk. It should be part of the changes we need to implement in order to merge it in core. I update the PLIP accordingly.

Member

ebrehault commented Apr 8, 2016

I think "Current toplevel toolbar item adds extra noise to the toolbar" should not be listed as a risk. It should be part of the changes we need to implement in order to merge it in core. I update the PLIP accordingly.

@thet

This comment has been minimized.

Show comment
Hide comment
@thet

thet Apr 12, 2016

Member

@gforcada in another project I'm using the Plone Link content type for external redirects, where I used nginx or apache redirects before. If you mean that.
However, +1 for this PLIP.

Member

thet commented Apr 12, 2016

@gforcada in another project I'm using the Plone Link content type for external redirects, where I used nginx or apache redirects before. If you mean that.
However, +1 for this PLIP.

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Apr 12, 2016

Contributor

@thet yes I know, but my use case is more about bulk updates rather than one at a time. So having an overview where to see all redirects and being able to upload a mapping that creates them automatically would be a real time saver for us.

Contributor

gforcada commented Apr 12, 2016

@thet yes I know, but my use case is more about bulk updates rather than one at a time. So having an overview where to see all redirects and being able to upload a mapping that creates them automatically would be a real time saver for us.

@ebrehault

This comment has been minimized.

Show comment
Hide comment
@ebrehault

ebrehault Apr 12, 2016

Member

The PLIP has been approved. See https://community.plone.org/t/framework-team-meeting-minutes-2016-04-12/1943
Regarding implementation: we have concerns with the current UI. So it need to be polished (we also mentionned it might be simpler to rewrite it).

Member

ebrehault commented Apr 12, 2016

The PLIP has been approved. See https://community.plone.org/t/framework-team-meeting-minutes-2016-04-12/1943
Regarding implementation: we have concerns with the current UI. So it need to be polished (we also mentionned it might be simpler to rewrite it).

@fredvd

This comment has been minimized.

Show comment
Hide comment
@fredvd

fredvd Apr 13, 2016

Member

There is a usability issue with exposing/managing the redirection storage to end users which I seen a few times in the past, curious if others have the same experience. Or did this already change in Plone 5?

There is no distinction between manually added redirects by users and automatically added redirects when you move/rename content. In a large site you would want to clean up those automatic redirects after a certain period because they clutter te redirect list, sometimes also cause confusion, etc.

But as soon as you open the redirects to end users there are also explicit redirects that you shouldn't delete or at least be able to distinguish from.

For me this is a reason not to install redirectiontool by default, only when users request it and I can explain this caveat.

It would be great as a first step if the stored aliases/redirects would have a datetime atrribute and a label to indicate if the redirect as created automatically by the system or through redirectiontool by the user.

Member

fredvd commented Apr 13, 2016

There is a usability issue with exposing/managing the redirection storage to end users which I seen a few times in the past, curious if others have the same experience. Or did this already change in Plone 5?

There is no distinction between manually added redirects by users and automatically added redirects when you move/rename content. In a large site you would want to clean up those automatic redirects after a certain period because they clutter te redirect list, sometimes also cause confusion, etc.

But as soon as you open the redirects to end users there are also explicit redirects that you shouldn't delete or at least be able to distinguish from.

For me this is a reason not to install redirectiontool by default, only when users request it and I can explain this caveat.

It would be great as a first step if the stored aliases/redirects would have a datetime atrribute and a label to indicate if the redirect as created automatically by the system or through redirectiontool by the user.

@tomgross

This comment has been minimized.

Show comment
Hide comment
@tomgross

tomgross Jun 8, 2016

Member

I think rewriting the product might be the better option:

  • use a behavior instead of managed_types
  • remove all the deprecated stuff

Testing the product I found a severe usability problem: If a redirect exists and another redirect is created with the same name no feedback is issued. I would expect a message: There is a redirect with this name/URL already. You have the following options: Use new redirect, Keep current redirect

Member

tomgross commented Jun 8, 2016

I think rewriting the product might be the better option:

  • use a behavior instead of managed_types
  • remove all the deprecated stuff

Testing the product I found a severe usability problem: If a redirect exists and another redirect is created with the same name no feedback is issued. I would expect a message: There is a redirect with this name/URL already. You have the following options: Use new redirect, Keep current redirect

@Rudd-O

This comment has been minimized.

Show comment
Hide comment
@Rudd-O

Rudd-O Sep 29, 2016

Contributor

This is going to be so awesome. Thank you folks!

Contributor

Rudd-O commented Sep 29, 2016

This is going to be so awesome. Thank you folks!

@svx

This comment has been minimized.

Show comment
Hide comment
@svx

svx Jul 11, 2017

Member

@staeff @datakurre

Nice work ! Thanks !

Would you mind to update the docs too ?

Since there is some UI involved a robot test for screen-shots would be super duper excellent uber superlecker awesome !

Thanks a lot !!!!

Member

svx commented Jul 11, 2017

@staeff @datakurre

Nice work ! Thanks !

Would you mind to update the docs too ?

Since there is some UI involved a robot test for screen-shots would be super duper excellent uber superlecker awesome !

Thanks a lot !!!!

@staeff

This comment has been minimized.

Show comment
Hide comment
@staeff

staeff Jul 11, 2017

Contributor

Hi @svx,

thanks for the heads up! I had it on the list to document it. Question: I was skimming the docs to see where it would fit, but I did not find a place. I was looking for a section where all the other controlpanels are documented. Did I miss to find it? If not, any suggestions where to put it?

Contributor

staeff commented Jul 11, 2017

Hi @svx,

thanks for the heads up! I had it on the list to document it. Question: I was skimming the docs to see where it would fit, but I did not find a place. I was looking for a section where all the other controlpanels are documented. Did I miss to find it? If not, any suggestions where to put it?

@svx

This comment has been minimized.

Show comment
Hide comment
@svx

svx Jul 11, 2017

Member

@staeff good point !

When it get merged into CMFPlone it should go into the /docs dir of the repo.

Currently the /docs repo of CMFPlone is using 'old style' and not following best practices.

IMHO it's time to change that :)

Long answer short put into /docs of CMFPlone, and after that I will create a PR which cleans up /docs and moves files to places where they belong.

Later we will 'fetch' /docs and will place it under the other docs on docs.plone.org, IMHO this should go under 'working with content'

@polyester what do you think ?

Member

svx commented Jul 11, 2017

@staeff good point !

When it get merged into CMFPlone it should go into the /docs dir of the repo.

Currently the /docs repo of CMFPlone is using 'old style' and not following best practices.

IMHO it's time to change that :)

Long answer short put into /docs of CMFPlone, and after that I will create a PR which cleans up /docs and moves files to places where they belong.

Later we will 'fetch' /docs and will place it under the other docs on docs.plone.org, IMHO this should go under 'working with content'

@polyester what do you think ?

@ebrehault ebrehault moved this from Stalled (approved with no activity) to In Process (approved) in PLIPs Jul 11, 2017

@datakurre

This comment has been minimized.

Show comment
Hide comment
@datakurre

datakurre Oct 4, 2017

Member

@staeff Would you able to create a checklist of missing parts, and possibly also create a WIP pull request for this? Obviously we missed Plone 5.1, but maybe we could get this merged soon after 5.1 final is out.

Member

datakurre commented Oct 4, 2017

@staeff Would you able to create a checklist of missing parts, and possibly also create a WIP pull request for this? Obviously we missed Plone 5.1, but maybe we could get this merged soon after 5.1 final is out.

@datakurre

This comment has been minimized.

Show comment
Hide comment
@svx

This comment has been minimized.

Show comment
Hide comment
@svx

svx Jan 4, 2018

Member

@staeff @datakurre is there something I can help with ?

I really need/want that thing :)

Member

svx commented Jan 4, 2018

@staeff @datakurre is there something I can help with ?

I really need/want that thing :)

@staeff

This comment has been minimized.

Show comment
Hide comment
@staeff

staeff Jan 4, 2018

Contributor

@svx @dataflake I have to apologize, I am the bottle neck here. I will give an update on the state of the work and make a WIP pr this weekend.

Contributor

staeff commented Jan 4, 2018

@svx @dataflake I have to apologize, I am the bottle neck here. I will give an update on the state of the work and make a WIP pr this weekend.

@staeff

This comment has been minimized.

Show comment
Hide comment
@staeff

staeff Jan 8, 2018

Contributor

@svx @datakurre I made a WIP pull request now. There are some tiny things that could be improved, as I see it. I'd be glad to get your opinions and questions.

Contributor

staeff commented Jan 8, 2018

@svx @datakurre I made a WIP pull request now. There are some tiny things that could be improved, as I see it. I'd be glad to get your opinions and questions.

@staeff

This comment has been minimized.

Show comment
Hide comment
@staeff

staeff Jan 9, 2018

Contributor

@svx here is a list of things, that are needed or would be nice to have from my perspective.

  • @@redirection-controlpanel (global alias managment) must be reachable through the @@overview-controlpanel
  • @@manage-aliases (alias management on an object) should be reachable from a content type. Suggested solution is the make it an action (that is hidden by default)
  • Confirmation dialogue when aliases are deleted
  • Translations are needed
  • User docs for the control-panel (#1486 (comment))

This is one is needed for der Freitag:

  • Add capability to add an external URL (p.a.redirector supports this)
Contributor

staeff commented Jan 9, 2018

@svx here is a list of things, that are needed or would be nice to have from my perspective.

  • @@redirection-controlpanel (global alias managment) must be reachable through the @@overview-controlpanel
  • @@manage-aliases (alias management on an object) should be reachable from a content type. Suggested solution is the make it an action (that is hidden by default)
  • Confirmation dialogue when aliases are deleted
  • Translations are needed
  • User docs for the control-panel (#1486 (comment))

This is one is needed for der Freitag:

  • Add capability to add an external URL (p.a.redirector supports this)
@svx

This comment has been minimized.

Show comment
Hide comment
@svx

svx Jan 9, 2018

Member

@staeff I can take care of the docs, no problem :)

Member

svx commented Jan 9, 2018

@staeff I can take care of the docs, no problem :)

@djay

This comment has been minimized.

Show comment
Hide comment
@djay

djay Jan 10, 2018

Member

Was there any update on changing the word alias? I see no reference to this change.

Member

djay commented Jan 10, 2018

Was there any update on changing the word alias? I see no reference to this change.

@djay

This comment has been minimized.

Show comment
Hide comment
@djay

djay Jan 10, 2018

Member

call it "url management".

Member

djay commented Jan 10, 2018

call it "url management".

@staeff

This comment has been minimized.

Show comment
Hide comment
@staeff

staeff Jan 10, 2018

Contributor

@djay okay.

Contributor

staeff commented Jan 10, 2018

@djay okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment