New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbox "only in this section" should come before searchbox in DOM for a11y reasons #1619

Closed
polyester opened this Issue Jun 2, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@polyester
Member

polyester commented Jun 2, 2016

After review by the Penn State a11y team, they ask for this change so screen reader users have a good chance of discovering it and using it.

Visually, it can stay where it is.

esteele added a commit to plone/plone.app.layout that referenced this issue Jul 5, 2017

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Jul 5, 2017

[fc] Repository: plone.app.layout
Branch: refs/heads/master
Date: 2017-07-03T14:24:14+03:00
Author: Paul Roeland (polyester) <paul@cleanclothes.org>
Commit: plone/plone.app.layout@05a8ad9

fixes plone/Products.CMFPlone#1619

because of https://www.w3.org/TR/WCAG20-TECHS/C27.html the 'only in this section' part should not be displayed after the input field, as in original issue description. 
I'll also make a change in Barcelonetta to align properly.

Files changed:
M plone/app/layout/viewlets/searchbox.pt
Repository: plone.app.layout
Branch: refs/heads/master
Date: 2017-07-05T12:09:17+03:00
Author: Paul Roeland (polyester) <paul@cleanclothes.org>
Commit: plone/plone.app.layout@8eea015

Update CHANGES.rst

Files changed:
M CHANGES.rst
Repository: plone.app.layout
Branch: refs/heads/master
Date: 2017-07-05T14:22:38+03:00
Author: Eric Steele (esteele) <eric@esteele.net>
Commit: plone/plone.app.layout@42a892b

Merge pull request #126 from polyester/master

fixes plone/Products.CMFPlone#1619

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/searchbox.pt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment