Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Portlet Design #163
Example implementation: plone/plone.app.portlets@c241e84
This commit does these replacements:
I've tested it with the bootstrap theme by adding these classes (see plone/plone.app.portlets@fb72d22, just an example!).
So our Less setup should add these classes:
(Updated: dd.portletItem -> section.portletContent instead of div.portletContent)
Should div.portlet not be section.portlet ?
Using the footer element
An important point to note is that you are not restricted to use oneelement per site, you can use multiple footers, each of which will then become the for that section of the document. You could therefore have a for a or an .
http://www.w3.org/html/wg/drafts/html/master/sections.html#the-section-element says "The section element is not a generic container element. When an element is needed only for styling purposes or as a convenience for scripting, authors are encouraged to use the div element instead." It looks like the latter is more the case here. But I'm no expert.
referenced this issue
Feb 11, 2014
But I think we will need different HTML for diferent portlets.
With this, the portlets HTML will be much more semantic.
This was referenced
Feb 11, 2014
be careful when going overboard with "aside" and other HTML5 tags. Most screenreaders unfortunately don't support it. ARIA roles are complementary, and supported. http://www.maxability.co.in/tag/html-5-accessibility-2/
another annoying Jaws bug is that headings are marked 'lower' in the hierarchy when inside an aside. So that a H2 effectively becomes a h4. That can be overcome by marking the portlet-headers themselves with the Aria role, so add: role="heading" to the first heading in the respective portlets.