Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list of plone_scripts to get rid of #1801

Open
jensens opened this Issue Oct 21, 2016 · 2 comments

Comments

@jensens
Copy link
Member

jensens commented Oct 21, 2016

I just checked the state of skins/plone_scripts and it looks there are some low hanging fruits around.

  • add_ext_editor.py seems completly outdated, I doubt this one is used anywhere

  • author_find_content.py this is not used on core at any place

  • browserDefault.py @ksuess

    • Products/ATContentTypes/skins/ATContentTypes/atct_topic_subtopics.pt
    • Products/ResourceRegistries/tools/BaseRegistry.py (gone in 5.2)
    • plone/app/content/browser/reviewlist.py
    • plone/app/content/browser/templates/content_status_history.pt
    • plone/app/querystring/tests/testQueryBuilder.py
  • canSelectDefaultPage.py

    • plone.app.content/plone/app/content/browser/templates/select_default_view.pt
    • Products.CMFPlone/Products/CMFPlone/skins/plone_scripts/canSelectDefaultPage.py
    • Products.CMFPlone/Products/CMFPlone/tests/testBrowserDefaultScripts.py
    • Products.CMFPlone/Products/CMFPlone/tests/testPloneView.py
  • check_id.py

    • various places in AT world
  • createMultiColumnList.py

    • Products.CMFPlone/Products/CMFPlone/browser/templates/search.pt
  • create_query_string.py

    • this is not used on core at any place
  • date_components_support.py

    • Products.Archetypes/Products/Archetypes/browser/templates/calendar_macros.pt (move to Archetypes!)
  • displayContentsTab.py

    • only place this string appears is Products.CMFPlone/Products/CMFPlone/browser/interfaces.py where it is defined on IPlone interface.
      fishy.
  • enableHTTPCompression.py

    • plone.app.layout/plone/app/layout/viewlets/httpheaders.py
  • externalEditorEnabled.py

    • plone.app.blob/src/plone/app/blob/profiles/file-replacement/types/ATFile.xml
    • plone.app.blob/src/plone/app/blob/profiles/image-replacement/types/ATImage.xml
    • plone.app.blob/src/plone/app/blob/profiles/sample/types/Blob.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/Document.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/Event.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/File.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/Image.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/Link.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/News_Item.xml
    • Products.CMFPlone/Products/CMFPlone/profiles/default/actions.xml
    • Products.CMFPlone/Products/CMFPlone/tests/testExternalEditorEnabled.py
    • Products.CMFPlone/Products/CMFPlone/utils.py
  • external_edit.py

    • plone.app.blob/src/plone/app/blob/profiles/file-replacement/types/ATFile.xml
    • plone.app.blob/src/plone/app/blob/profiles/image-replacement/types/ATImage.xml
    • plone.app.blob/src/plone/app/blob/profiles/sample/types/Blob.xml
    • plone.app.upgrade/plone/app/upgrade/v40/alphas.py
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/Document.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/Event.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/File.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/Image.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/Link.xml
    • Products.ATContentTypes/Products/ATContentTypes/profiles/default/types/News_Item.xml
    • Products.CMFPlone/Products/CMFPlone/profiles/default/actions.xml
    • Products.CMFPlone/Products/CMFPlone/profiles/default/types/Discussion_Item.xml
    • Products.CMFPlone/Products/CMFPlone/skins/plone_scripts/add_ext_editor.py
    • Products.CMFPlone/Products/CMFPlone/skins/plone_scripts/external_edit.py
    • Products.CMFPlone/Products/CMFPlone/tests/testExternalEditorEnabled.py
    • Products.contentmigration/Products/contentmigration/profiles/testing/types/CMF_Document.xml
  • folder_publish.cpy

    • Products.CMFFormController/Products/CMFFormController/tests/testRedirectTo.py
    • plone.app.content/plone/app/content/browser/content_status_history.py
    • Products.CMFPlone/Products/CMFPlone/tests/testContentPublishing.py
  • formatColumns.py

    • this is not used on core at any place,
    • except in its own test at
      Products.CMFPlone/Products/CMFPlone/tests/testSecurity.py
  • generateUniqueId.py

    • Products.LinguaPlone/Products/LinguaPlone/tests/test_api.py
    • archetypes.multilingual/archetypes/multilingual/browser/add.py
    • Products.Archetypes/Products/Archetypes/skins/archetypes/createObject.cpy
    • Products.Archetypes/Products/Archetypes/skins/archetypes/add_reference.cpy
    • Products.CMFPlone/Products/CMFPlone/tests/testNavigationView.py
  • getAllowedTypes.py

    • unused
  • getFolderContents.py

    • plone.app.content/plone/app/content/browser/selection.py
    • plone.app.content/plone/app/content/tests/test_actions.py
    • plone.app.contentlisting/README.rst
    • Products.ATContentTypes/Products/ATContentTypes/skins/ATContentTypes/atct_topic_subtopics.pt
    • Products.ATContentTypes/Products/ATContentTypes/skins/ATContentTypes/atctListAlbum.py
    • Products.ATContentTypes/Products/ATContentTypes/tests/test_browserdefaultmixin.py
    • Products.CMFPlone/Products/CMFPlone/skins/plone_content/folder_listing.pt
    • Products.CMFPlone/Products/CMFPlone/tests/testNavTree.py
    • Products.CMFPlone/Products/CMFPlone/tests/testSecurity.py
  • getGlobalPortalRoles.py

    • this is not used in core at any place
  • getNotAddableTypes.py

    • only used un unused Products.CMFPlone/Products/CMFPlone/skins/plone_scripts/getAllowedTypes.py
  • getObjectsFromPathList.py @reinhardt

    • plone.app.content/plone/app/content/browser/templates/content_status_history.pt
  • getObjSize.py @reinhardt

    • used at several places, needs check if its always this script or some other method.
  • getPopupScript.py

    • this is not used in core at any place
  • getPortalTypeList.py

    • this is not used in core at any place
  • getPortalTypes.py

    • this is not used in core at any place
  • getSelectableViews.py

    • only used it its own test
    • Products.CMFPlone/Products/CMFPlone/tests/testBrowserDefaultScripts.p
  • hasIndexHtml.py

    • only used in its own test
    • Products.CMFPlone/Products/CMFPlone/tests/testBrowserDefaultScripts.p
  • isExpired.py

    • plone.app.content/plone/app/content/browser/reviewlist.py
    • plone.app.content/plone/app/content/browser/templates/content_status_history.pt
    • Products.ATContentTypes/Products/ATContentTypes/skins/ATContentTypes/atct_topic_subtopics.pt
    • Products.CMFPlone/Products/CMFPlone/tests/testContentPublishing.py
  • mail_password.py

    • difficult to figure out (term used in other ways), needs deeper investigations
  • my_worklist.py

    • plone.app.content/plone/app/content/browser/reviewlist.py
    • plone.app.workflow/plone/app/workflow/tests/test_plone_workflow.py
    • Products.CMFPlacefulWorkflow/Products/CMFPlacefulWorkflow/tests/testCMFPlacefulWorkflow.py
  • navigationParent.py

    • only used in its own test
    • Products.CMFPlone/Products/CMFPlone/tests/testNavigationParent.py
  • plone.css.py

    • plone.app.debugtoolbar/src/plone/app/debugtoolbar/browser/theme.pt
    • Products.LinguaPlone/Products/LinguaPlone/skins/LinguaPlone/translationbrowser_popup.pt
    • Products.ResourceRegistries/Products/ResourceRegistries/www/csscomposition.zpt (gone in 5.2)
  • plone_log.py

    • last occurrence was in CMFEditions, which was recently removed
  • pretty_title_or_id.py

    • various places, need detailed check
  • queryCatalog.py

    • conflicts with other method of same name, needs detailed check
    • see also #278
  • raiseUnauthorized.py @mauritsvanrees

    • Products.CMFPlacefulWorkflow/Products/CMFPlacefulWorkflow/skins/CMFPlacefulWorkflow/prefs_workflow_localpolicies_form.pt
  • redirectToReferrer.py

    • plone.app.content/plone/app/content/browser/templates/content_status_history.pt
  • returnNone.py

    • Products.CMFPlone/Products/CMFPlone/controlpanel/browser/usergroups_groupdetails.pt
    • and tests
  • reverseList.py

    • only in own tests
    • Products.CMFPlone/Products/CMFPlone/tests/scripts.txt
  • setAuthCookie.py

    • Products.CMFCore/Products/CMFCore/CookieCrumbler.py
    • Products.PlonePAS/src/Products/PlonePAS/plugins/cookie_handler.py
  • show_id.py

    • Products.Archetypes/Products/Archetypes/skins/archetypes/widgets/zid.pt
  • sort_modified_ascending.py

    • this is not used in core at any place
  • sortObjects.py

    • Products.CMFPlone/Products/CMFPlone/skins/plone_scripts/getAllowedTypes.py
    • Products.CMFPlone/Products/CMFPlone/tests/testSortObjects.py
  • toLocalizedTime.py

    • various places, needs detailed check
  • translate.py

    • various places, needs detailed check
  • unique.py

    difficult to grep for, needs detailed check
    tested in scripts.txt

  • utranslate.py

    various places, needs detailed check

@jensens

This comment has been minimized.

Copy link
Member Author

jensens commented Oct 21, 2016

see also #1802

jensens added a commit that referenced this issue Mar 9, 2017

jensens added a commit that referenced this issue Mar 9, 2017

jensens added a commit that referenced this issue Aug 13, 2018

sunew added a commit to plone/plone.app.upgrade that referenced this issue Sep 6, 2018

sunew added a commit to plone/plone.app.upgrade that referenced this issue Sep 6, 2018

remove the jquery-highlightsearchterms resource, and the - now empty …
…- plone_ecmascript skin layer. See https://github.com/plone/Products.CMFPlone/pull/1963/commits and plone/Products.CMFPlone#1811 plone/Products.CMFPlone#1801

removing records (wip)

remove jquery-highlightsearchterms from the plone-legacy bundle

c

sunew added a commit that referenced this issue Sep 6, 2018

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Sep 9, 2018

[fc] Repository: plone.app.upgrade
Branch: refs/heads/master
Date: 2018-09-06T18:21:00+02:00
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plone.app.upgrade@6bab181

remove the jquery-highlightsearchterms resource, and the - now empty - plone_ecmascript skin layer. See https://github.com/plone/Products.CMFPlone/pull/1963/commits and plone/Products.CMFPlone#1811 plone/Products.CMFPlone#1801

removing records (wip)

remove jquery-highlightsearchterms from the plone-legacy bundle

c

Files changed:
A plone/app/upgrade/v52/profiles/to_alpha1/registry.xml
M CHANGES.rst
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/profiles/to_alpha1/skins.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-09-06T20:23:08+02:00
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plone.app.upgrade@c979968

Also remove the jquery-highlightsearchterms resource, and the plone_ecmascript skin layer for plone 5.1.4

Files changed:
A plone/app/upgrade/v51/profiles/to_514/skins.xml
M CHANGES.rst
M plone/app/upgrade/v51/configure.zcml
M plone/app/upgrade/v51/final.py
M plone/app/upgrade/v51/profiles/to_514/registry.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-09-08T12:26:59+02:00
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plone.app.upgrade@0c1c1ee

Update the compilation date of the plone-legacy bundle, to force recompilation

Files changed:
M plone/app/upgrade/v51/profiles/to_514/registry.xml
M plone/app/upgrade/v52/profiles/to_alpha1/registry.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-09-09T08:41:13+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@8d8f25d

Merge pull request #170 from plone/remove-highlightsearchterms

Remove jquery-highlightsearchterms and plone_ecmascript layer

Files changed:
A plone/app/upgrade/v51/profiles/to_514/skins.xml
A plone/app/upgrade/v52/profiles/to_alpha1/registry.xml
M CHANGES.rst
M plone/app/upgrade/v51/configure.zcml
M plone/app/upgrade/v51/final.py
M plone/app/upgrade/v51/profiles/to_514/registry.xml
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/profiles/to_alpha1/skins.xml

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Sep 9, 2018

[fc] Repository: plone.app.upgrade
Branch: refs/heads/master
Date: 2018-09-06T18:21:00+02:00
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plone.app.upgrade@6bab181

remove the jquery-highlightsearchterms resource, and the - now empty - plone_ecmascript skin layer. See https://github.com/plone/Products.CMFPlone/pull/1963/commits and plone/Products.CMFPlone#1811 plone/Products.CMFPlone#1801

removing records (wip)

remove jquery-highlightsearchterms from the plone-legacy bundle

c

Files changed:
A plone/app/upgrade/v52/profiles/to_alpha1/registry.xml
M CHANGES.rst
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/profiles/to_alpha1/skins.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-09-06T20:23:08+02:00
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plone.app.upgrade@c979968

Also remove the jquery-highlightsearchterms resource, and the plone_ecmascript skin layer for plone 5.1.4

Files changed:
A plone/app/upgrade/v51/profiles/to_514/skins.xml
M CHANGES.rst
M plone/app/upgrade/v51/configure.zcml
M plone/app/upgrade/v51/final.py
M plone/app/upgrade/v51/profiles/to_514/registry.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-09-08T12:26:59+02:00
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plone.app.upgrade@0c1c1ee

Update the compilation date of the plone-legacy bundle, to force recompilation

Files changed:
M plone/app/upgrade/v51/profiles/to_514/registry.xml
M plone/app/upgrade/v52/profiles/to_alpha1/registry.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-09-09T08:41:13+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@8d8f25d

Merge pull request #170 from plone/remove-highlightsearchterms

Remove jquery-highlightsearchterms and plone_ecmascript layer

Files changed:
A plone/app/upgrade/v51/profiles/to_514/skins.xml
A plone/app/upgrade/v52/profiles/to_alpha1/registry.xml
M CHANGES.rst
M plone/app/upgrade/v51/configure.zcml
M plone/app/upgrade/v51/final.py
M plone/app/upgrade/v51/profiles/to_514/registry.xml
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/profiles/to_alpha1/skins.xml

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Sep 9, 2018

[fc] Repository: plone.app.upgrade
Branch: refs/heads/master
Date: 2018-09-06T18:21:00+02:00
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plone.app.upgrade@6bab181

remove the jquery-highlightsearchterms resource, and the - now empty - plone_ecmascript skin layer. See https://github.com/plone/Products.CMFPlone/pull/1963/commits and plone/Products.CMFPlone#1811 plone/Products.CMFPlone#1801

removing records (wip)

remove jquery-highlightsearchterms from the plone-legacy bundle

c

Files changed:
A plone/app/upgrade/v52/profiles/to_alpha1/registry.xml
M CHANGES.rst
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/profiles/to_alpha1/skins.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-09-06T20:23:08+02:00
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plone.app.upgrade@c979968

Also remove the jquery-highlightsearchterms resource, and the plone_ecmascript skin layer for plone 5.1.4

Files changed:
A plone/app/upgrade/v51/profiles/to_514/skins.xml
M CHANGES.rst
M plone/app/upgrade/v51/configure.zcml
M plone/app/upgrade/v51/final.py
M plone/app/upgrade/v51/profiles/to_514/registry.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-09-08T12:26:59+02:00
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plone.app.upgrade@0c1c1ee

Update the compilation date of the plone-legacy bundle, to force recompilation

Files changed:
M plone/app/upgrade/v51/profiles/to_514/registry.xml
M plone/app/upgrade/v52/profiles/to_alpha1/registry.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-09-09T08:41:13+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@8d8f25d

Merge pull request #170 from plone/remove-highlightsearchterms

Remove jquery-highlightsearchterms and plone_ecmascript layer

Files changed:
A plone/app/upgrade/v51/profiles/to_514/skins.xml
A plone/app/upgrade/v52/profiles/to_alpha1/registry.xml
M CHANGES.rst
M plone/app/upgrade/v51/configure.zcml
M plone/app/upgrade/v51/final.py
M plone/app/upgrade/v51/profiles/to_514/registry.xml
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/profiles/to_alpha1/skins.xml

erral added a commit that referenced this issue Sep 14, 2018

@ksuess ksuess self-assigned this Oct 1, 2018

@reinhardt reinhardt self-assigned this Oct 1, 2018

reinhardt added a commit that referenced this issue Oct 1, 2018

reinhardt added a commit that referenced this issue Oct 2, 2018

reinhardt added a commit that referenced this issue Oct 4, 2018

reinhardt added a commit that referenced this issue Oct 4, 2018

gforcada added a commit that referenced this issue Oct 5, 2018

gforcada added a commit that referenced this issue Oct 5, 2018

reinhardt added a commit that referenced this issue Oct 5, 2018

reinhardt added a commit to plone/plone.app.content that referenced this issue Oct 5, 2018

@mauritsvanrees mauritsvanrees referenced this issue Oct 5, 2018

Closed

Use new utils.check_id from CMFPlone #60

2 of 2 tasks complete

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Oct 5, 2018

[fc] Repository: plone.app.blob
Branch: refs/heads/master
Date: 2018-10-02T18:09:50+02:00
Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com>
Commit: plone/plone.app.blob@130d380

Removed usage of getObjSize script from tests.
Also declared dependency on Products.CMFPlone.
plone/Products.CMFPlone#1801

Files changed:
M setup.py
M src/plone/app/blob/tests/test_replacements.py
Repository: plone.app.blob

Branch: refs/heads/master
Date: 2018-10-02T18:14:23+02:00
Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com>
Commit: plone/plone.app.blob@dfaf548

Added changelog entry.

Files changed:
M CHANGES.rst
Repository: plone.app.blob

Branch: refs/heads/master
Date: 2018-10-05T20:16:16+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.blob@4de7add

Merge pull request #52 from plone/1801-get-size

Removed usage of getObjSize script from tests.

Files changed:
M CHANGES.rst
M setup.py
M src/plone/app/blob/tests/test_replacements.py

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Oct 5, 2018

[fc] Repository: plone.app.content
Branch: refs/heads/master
Date: 2018-10-05T12:02:57+02:00
Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com>
Commit: plone/plone.app.content@738b89b

Replaced another usage of getObjSize.
plone/Products.CMFPlone#1801

Files changed:
M plone/app/content/browser/content_status_history.py
M plone/app/content/browser/templates/content_status_history.pt
Repository: plone.app.content

Branch: refs/heads/master
Date: 2018-10-05T20:17:18+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.content@6031bad

Merge pull request #169 from plone/1801-get-size-part-2

Replaced another usage of getObjSize

Files changed:
M plone/app/content/browser/content_status_history.py
M plone/app/content/browser/templates/content_status_history.pt
@mauritsvanrees

This comment has been minimized.

Copy link
Member

mauritsvanrees commented Oct 22, 2018

Status as of 22 October 2018: 12 scripts to go in Products.CMFPlone/skins/plone_scripts:

browserDefault.py
externalEditorEnabled.py
external_edit.py
folder_publish.cpy
generateUniqueId.py
getFolderContents.py
pretty_title_or_id.py
queryCatalog.py
toLocalizedTime.py
translate.py
unique.py
utranslate.py

(The list in the main text of this issue is leading.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.