Merge translations into plone.app.locales

[esteele]

We have some packages that started their lives as non-core addons, but didn't merge their translations into plone.app.locales when they were added to core.

See:

• Move translations to plone.app.locales. plone.app.discussion#66
• move translations to plone domain and maybe even plone.app.locales plone.app.event#181
• move translations to plone.app.locales plone.app.dexterity#158
• Move Translations to plone.app.locales plone.app.multilingual#191
• Move Translations to plone.app.locales plone.app.versioningbehavior#19
• changed i18n_domain to "plone" plone.app.lockingbehavior#3
• Move translations to plone.app.locales plone.schemaeditor#34
• zopefoundation/plone.z3cform (still no ticket, pending an answer on Transfer plone.z3cform to plone org? buildout.coredev#139)
• Remove own i18n domain plone.schema#2
• Translations to p.a.locale plone.formwidget.recurrence#19
• Remove locales folder plone.formwidget.namedfile#19 (and the previous pr)
• Use plone i18n domain plone.formwidget.datetime#16
• Use plone i18n domain plone.formwidget.autocomplete#17
• Move Translations to plone.app.locales plone.formwidget.contenttree#22
• Move Translations to plone.app.locales plone.app.caching#20 (plone.app.caching.po files in plone/app/locales/locales-addons but need to be moved to plone domain)
• Moved translations to plone.app.locales plone.app.referenceablebehavior#7
• Move Translations to plone.app.locales plone.app.widgets#125 (python part, js already in widgets.pot generated from mockup)
• Change i18n_domain to "plone" plone.cachepurging#4
• Use plone i18n domain plone.caching#2
• Move translations into plone.app.locales plone.dexterity#79
• Update i18n domain plone.directives.form#4
• Move translations to plone.app.locales Products.CMFDiffTool#31

[edit by @jensens] added 2 packages
[edit by @gforcada] added a bunch more

HOW TO
[remixed by @gforcada from https://github.com/plone/plone.app.event/issues/181#issuecomment-96406149 thanks @vincentfretin]

• get a working buildout.coredev checkout
• checkout the target package (./bin/develop co $PACKAGE_NAME)
• modify the target package to use the plone domain (see plone/plone.app.discussion@0713bcd and plone/plone.app.discussion@19fe254)
• modify experimental/i18n.cfg in buildout.coredev 5.1 to include the target package in plone domain. See plone/buildout.coredev@802549d
• run bin/buildout -c experimental/i18n.cfg on buildout.coredev 5.1
• use bin/i18n plone to regenerate plone.pot and resync plone files. (If there is any removed messages, be sure to look if this is normal, it may be an issue you have to fix before continuing your work)
• use bin/i18ndude admix command to transfer translated messages from the target package to plone.po for each language. Something like this:

P_A_LOCALES="src/plone.app.locales/plone/app/locales/locales"
TARGET_PACKAGE="src/plone.app.discussion/plone/app/discussion/locales"
PO_FILE="plone.app.discusion.po"
locales=`cd ${TARGET_PACKAGE}; ls | /bin/grep -v .pot`

for locale in $locales;
do
    bin/i18ndude admix ${P_A_LOCALES}/$locale/LC_MESSAGES/plone.po ${TARGET_PACKAGE}/$locale/LC_MESSAGES/${PO_FILE} > ${P_A_LOCALES}/$locale/LC_MESSAGES/plone.po.tmp
    mv ${P_A_LOCALES}/$locale/LC_MESSAGES/plone.po.tmp ${P_A_LOCALES}/$locale/LC_MESSAGES/plone.po
done

• commit, push (on branches) and create pull requests for both the target package and plone.app.locales
• add an extra commit on the target package to remove the locales folder (don't forget to remove the i18n:registerTranslations directive in configure.zcml)
• another pull request on buildout.coredev with the experimental/i18n.cfg update
• they need to be merged all 3 together
• remember to add changelog entries on the target package and plone.app.locales!
• last thing: add the pull request on this comment and tick the checkbox!

[bloodbare]

There is also plone.app.multilingual

[vincentfretin]

and maybe plone.app.multilingual and plone.app.versioningbehavior

[claytonc]

I found plone.app.contenttypes and plone.app.lockingbehavior not translated.
I'm already translating it.
I will add in plone.app.locales.
The files "plone.app.contenttypes.pot" and "plone.app.lockingbehavior" has to be created inside locales-addons? Correct ?

[jensens]

plone.app.contenttypes are mainly in the plone i18n-domain. Is there an own plone.app.contenttypes i18n-domain defined somehwere? if yes: create a pot file for it.

plone.app.versioningbehavior is translated here:
https://github.com/plone/plone.app.versioningbehavior/tree/master/plone/app/versioningbehavior/locales
So files has just to be copied over to plone.app.locales and removed at the original place.

[vincentfretin]

plone.app.contenttypes translations are in the plone domain in plone.app.locales.

[claytonc]

Is it better to change "plone.app.contenttypes" domain at the file plone.app.contenttypes/plone/app/contenttypes/behaviors/configure.zcml to "plone"?

[jensens]

plone.app.lockingbehavior has one string Locking ind the domain plone.app.lockingbehavior - I propose to change the zcml and put it into the plone domain and translate it there.