the advanced_search input is present twice #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gagaro
force-pushed
the
fix-advanced_search
branch
from
7354358
to
a1f15c0
Compare
|
Lgtm |
| @@ -1,4 +1,4 @@ | |||
| .. This file should contain the changes for the last release only, which | |||
| [6~].. This file should contain the changes for the last release only, which | |||
There was a problem hiding this comment.
Is that maybe a typo? What is this [6~] for?
There was a problem hiding this comment.
Sorry about that, it's my emacs.
There was a problem hiding this comment.
no problem, it's always a good idea to double check your commits before pushing, but that's what pull requests for as well :-)
I started a jenkins job to test the pull request, let's see if jenkins agrees on your changes.
There was a problem hiding this comment.
I usually do, but this one was literally 20 seconds before I had to left 😋 . Thanks for the review.
The second occurence is [there](https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/browser/templates/search.pt#L64-L65). I think the first one shouldn't be there. We have the advanced_query parameter in double with both False and True as a value if we keep them both.
Gagaro
force-pushed
the
fix-advanced_search
branch
from
a1f15c0
to
02b5748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second occurence is there.
I think the first one shouldn't be there. We have the advanced_query parameter in double with both False and True as a value if we keep them both.