New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor filter control panel and tests #2098

Merged
merged 5 commits into from Jul 28, 2017

Conversation

Projects
None yet
6 participants
@MrTango
Contributor

MrTango commented Jul 6, 2017

No description provided.

@tisto tisto self-requested a review Jul 7, 2017

@@ -37,6 +37,7 @@
'lxml',
'mock',
'plone.app.robotframework>0.9.16',
'robotframework-debuglibrary',

This comment has been minimized.

@tisto

tisto Jul 7, 2017

Member

@MrTango I don't think this should be declared as a dependency here. I am sure this is already declared somewhere in plone.app.robotframework. cc @datakurre

@tisto

tisto Jul 7, 2017

Member

@MrTango I don't think this should be declared as a dependency here. I am sure this is already declared somewhere in plone.app.robotframework. cc @datakurre

This comment has been minimized.

@datakurre

datakurre Jul 9, 2017

Member

@tisto It's not a default dependency. "Debug" keyword in p.a.robotframework is a bit fancy. It is dependency with [debug] extras, but that can only be defined in buildout.

  1. open debuglibrary console when that's available
  2. pause with dialog when that dialog is supported by python (it's optional Python build dep)
  3. as last fallback stops with pdb

That said, it's not a perfect dependency. A better option would have been to put it somewhere into buildout.coredev so that's its included in modules of bin/test, but we didn't immediately find the correct testrunner recipe option for that.

@datakurre

datakurre Jul 9, 2017

Member

@tisto It's not a default dependency. "Debug" keyword in p.a.robotframework is a bit fancy. It is dependency with [debug] extras, but that can only be defined in buildout.

  1. open debuglibrary console when that's available
  2. pause with dialog when that dialog is supported by python (it's optional Python build dep)
  3. as last fallback stops with pdb

That said, it's not a perfect dependency. A better option would have been to put it somewhere into buildout.coredev so that's its included in modules of bin/test, but we didn't immediately find the correct testrunner recipe option for that.

@tisto

tisto approved these changes Jul 7, 2017

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Jul 13, 2017

Contributor

@MrTango as the branch needed to be rebased, I did it while removing those extra commits of merging with master (pro tip: rebase rather than pull please!).

Before force pushing the branch I double checked that your tree and my rebased tree had exactly the same code bit by bit.

Contributor

gforcada commented Jul 13, 2017

@MrTango as the branch needed to be rebased, I did it while removing those extra commits of merging with master (pro tip: rebase rather than pull please!).

Before force pushing the branch I double checked that your tree and my rebased tree had exactly the same code bit by bit.

@agitator agitator merged commit fdb0ba5 into master Jul 28, 2017

3 checks passed

Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.1 Job finished with success status
Details

@agitator agitator deleted the midsummersprint_fix_transforms branch Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment