New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ‘Show Toolbar’ permission. #2100

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
3 participants
@agitator
Member

agitator commented Jul 7, 2017

No description provided.

@datakurre

This comment has been minimized.

Show comment
Hide comment
@datakurre

datakurre Jul 9, 2017

Member

Pull is missing description, but this was supposed to be usable with

plone/plone.app.layout#128 and
plone/plone.app.layout#129

to be able to optionally limit toolbar to show e.g. only for Contributors/Editors/Reviewers while only showing a Plone 4 style membertools dropdown for authenticated users (this does not change the default behvior).

Member

datakurre commented Jul 9, 2017

Pull is missing description, but this was supposed to be usable with

plone/plone.app.layout#128 and
plone/plone.app.layout#129

to be able to optionally limit toolbar to show e.g. only for Contributors/Editors/Reviewers while only showing a Plone 4 style membertools dropdown for authenticated users (this does not change the default behvior).

@thet

This comment has been minimized.

Show comment
Hide comment
@thet

thet Jul 13, 2017

Member

LGTM.
Some documentation on how to use this would be nice, but that's not a blocker.

Member

thet commented Jul 13, 2017

LGTM.
Some documentation on how to use this would be nice, but that's not a blocker.

@thet thet merged commit e03f160 into master Jul 13, 2017

3 checks passed

Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.1 Job finished with success status
Details

@thet thet deleted the show_toolbar_permission branch Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment