Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.3.x Hotfix20200121 Password #3025

Merged
merged 1 commit into from Feb 11, 2020
Merged

4.3.x Hotfix20200121 Password #3025

merged 1 commit into from Feb 11, 2020

Conversation

gotcha
Copy link
Member

@gotcha gotcha commented Jan 22, 2020

Password strength checks were not always checked

see #3021

better branch name, supercedes #3022

@mister-roboto
Copy link

@gotcha thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mauritsvanrees
mauritsvanrees approved these changes Jan 22, 2020
View reviewed changes
Copy link
Sponsor Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
I have added the tests to your branch.

@mauritsvanrees
Copy link
Sponsor Member

@jenkins-plone-org please run jobs

@gotcha
Copy link
Member Author

gotcha commented Jan 22, 2020 •
edited

@mauritsvanrees Thanks for the tests !

What is the practice for changelog ?

Does towncrier accepts filenames like 3021-password.bugfix ?

@mauritsvanrees
Copy link
Sponsor Member

No. But you can do 3021.bugfix.1, 3021.bugfix.2, etc.

@gotcha
Copy link
Member Author

gotcha commented Jan 22, 2020

@mauritsvanrees Should I squash commits before merging ? a single commit might be easier to cherry-pick on other branches.

@gotcha gotcha force-pushed the merge-hotfix-20200121-4.3.x-password branch from 161c4f3 to c0c1913 Compare January 22, 2020 21:03
@mauritsvanrees
Password strength checks were not always checked
96e8a55 
Include Hotfix 20200121 with tests
@mauritsvanrees mauritsvanrees force-pushed the merge-hotfix-20200121-4.3.x-password branch from c0c1913 to 96e8a55 Compare January 23, 2020 10:55
@mauritsvanrees
Copy link
Sponsor Member

There were two test failures. One is actually good: code was trying to set a password of three characters, which worked until now, but not anymore. I updated the test and force pushed it.
The other is a failing robot test. It has been a while since I have run robot tests locally, and currently it does not work, so I can't check it.
Maybe it is flaky:
@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Sponsor Member

@jenkins-plone-org please run jobs

@mauritsvanrees mauritsvanrees merged commit 7d495b8 into 4.3.x Feb 11, 2020
@mauritsvanrees mauritsvanrees deleted the merge-hotfix-20200121-4.3.x-password branch February 11, 2020 11:46
@mauritsvanrees mauritsvanrees mentioned this pull request Feb 11, 2020
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gotcha @mister-roboto @mauritsvanrees