Update image_view_fullscreen.pt for mobile friendliness #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vangheem
added a commit
that referenced
this pull request
Mar 28, 2015
Update image_view_fullscreen.pt for mobile friendliness
fulv
added a commit
to plone/plone.app.contenttypes
that referenced
this pull request
Mar 28, 2015
see plone/Products.CMFPlone#407 Google complains loudly about this template, and will deduct mobile karma points. Also, using a different `viewport` meta directive than sunburst's default, for better accessibility. See: plone/Products.CMFPlone#389
|
But see: #389 about the I added the same change to plone.app.contenttypes: plone/plone.app.contenttypes#219 |
thet
added a commit
to plone/buildout.coredev
that referenced
this pull request
Mar 29, 2015
Branch: refs/heads/master Date: 2015-03-28T12:17:33-07:00 Author: Fulvio Casali (fulv) <fulviocasali@gmail.com> Commit: plone/plone.app.contenttypes@4eff2ea Update image_view_fullscreen.pt for mobile friendliness see plone/Products.CMFPlone#407 Google complains loudly about this template, and will deduct mobile karma points. Also, using a different `viewport` meta directive than sunburst's default, for better accessibility. See: plone/Products.CMFPlone#389 Files changed: M plone/app/contenttypes/browser/templates/image_view_fullscreen.pt Repository: plone.app.contenttypes Branch: refs/heads/master Date: 2015-03-28T12:20:35-07:00 Author: Fulvio Casali (fulv) <fulviocasali@gmail.com> Commit: plone/plone.app.contenttypes@1e6fb9f Add changelog entry Files changed: M docs/CHANGES.rst Repository: plone.app.contenttypes Branch: refs/heads/master Date: 2015-03-29T22:38:13+02:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@f6b459a Merge pull request #219 from plone/fulv-patch-1 Update image_view_fullscreen.pt for mobile friendliness Files changed: M docs/CHANGES.rst M plone/app/contenttypes/browser/templates/image_view_fullscreen.pt
fulv
added a commit
to plone/plone.app.contenttypes
that referenced
this pull request
Mar 29, 2015
see plone/Products.CMFPlone#407 Google complains loudly about this template, and will deduct mobile karma points. Also, using a different `viewport` meta directive than sunburst's default, for better accessibility. See: plone/Products.CMFPlone#389
pbauer
added a commit
to plone/buildout.coredev
that referenced
this pull request
Apr 7, 2015
Branch: refs/heads/1.1.x Date: 2015-02-26T14:54:16+01:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.app.contenttypes@fb13be1 move everthing to __call__ Files changed: M plone/app/contenttypes/browser/collection.py M plone/app/contenttypes/browser/folder.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T14:54:31+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@52e45df Revert "move everthing to __call__" This reverts commit 0a0adf182c8d6a4e5b98328648eac4e8effb082e. Files changed: M plone/app/contenttypes/browser/collection.py M plone/app/contenttypes/browser/folder.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T14:54:41+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@f5b44ad move code out of __init__ into properties, as __init__ is not security wrapped Files changed: M plone/app/contenttypes/browser/folder.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T14:54:57+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@b5af51b results + filter refactoring Files changed: M plone/app/contenttypes/browser/collection.py M plone/app/contenttypes/browser/folder.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T14:57:06+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@7cba13f robot tests for refactored unified listing views Conflicts: buildout.d/checkouts.cfg buildout.d/sources.cfg Files changed: M buildout.d/checkouts.cfg M buildout.d/sources.cfg M plone/app/contenttypes/tests/robot/test_folderlisting.robot M plone/app/contenttypes/tests/robot/variables.py M setup.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T14:57:25+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@ec45724 prettyfying html Files changed: A plone/app/contenttypes/browser/templates/listing_album.pt Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T14:58:29+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@32ccadd unify folder_album_view and thumbnail_view into album_view Conflicts: plone/app/contenttypes/browser/configure.zcml Files changed: M docs/CHANGES.rst M plone/app/contenttypes/behaviors/collection.py M plone/app/contenttypes/browser/collection.py M plone/app/contenttypes/browser/configure.zcml M plone/app/contenttypes/browser/folder.py M plone/app/contenttypes/browser/templates/listing_album.pt M plone/app/contenttypes/tests/robot/test_folderlisting.robot M plone/app/contenttypes/tests/test_collection.py D plone/app/contenttypes/browser/templates/folder_album_view.pt D plone/app/contenttypes/browser/templates/thumbnail_view.pt Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T14:58:44+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@7680ac9 test fix Files changed: M plone/app/contenttypes/tests/robot/test_folderlisting.robot Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T14:59:36+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@038d57c Register folder and collection views under the same name. Old registrations are kept for BBB compatibility. Conflicts: plone/app/contenttypes/browser/configure.zcml Files changed: M docs/CHANGES.rst M plone/app/contenttypes/browser/configure.zcml M plone/app/contenttypes/profiles/default/types/Collection.xml M plone/app/contenttypes/profiles/default/types/Folder.xml M plone/app/contenttypes/tests/test_collection.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T14:59:51+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@bb000d6 cleanup Files changed: D plone/app/contenttypes/browser/album_view.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T14:59:59+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@2c3c37f dont depend on unreleased... Files changed: M setup.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T15:01:20+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@58d7a77 reformat all templates Conflicts: plone/app/contenttypes/browser/templates/archetypes_warning_viewlet.pt Files changed: M docs/CHANGES.rst M plone/app/contenttypes/browser/templates/archetypes_warning_viewlet.pt M plone/app/contenttypes/browser/templates/document.pt M plone/app/contenttypes/browser/templates/file.pt M plone/app/contenttypes/browser/templates/full_view.pt M plone/app/contenttypes/browser/templates/full_view_item.pt M plone/app/contenttypes/browser/templates/image.pt M plone/app/contenttypes/browser/templates/image_view_fullscreen.pt M plone/app/contenttypes/browser/templates/link.pt M plone/app/contenttypes/browser/templates/listing.pt M plone/app/contenttypes/browser/templates/listing_album.pt M plone/app/contenttypes/browser/templates/listing_summary.pt M plone/app/contenttypes/browser/templates/listing_tabular.pt M plone/app/contenttypes/browser/templates/newsitem.pt Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T15:58:53+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@4f16676 use new view names in templates, tests and upgrades Files changed: M plone/app/contenttypes/browser/configure.zcml M plone/app/contenttypes/browser/templates/full_view.pt M plone/app/contenttypes/browser/templates/listing_summary.pt M plone/app/contenttypes/migration/migration.py M plone/app/contenttypes/migration/topics.py M plone/app/contenttypes/profiles/default/types/Collection.xml M plone/app/contenttypes/profiles/default/types/Folder.xml M plone/app/contenttypes/tests/robot/test_folderlisting.robot M plone/app/contenttypes/tests/test_behaviors_collection.py M plone/app/contenttypes/tests/test_collection.py M plone/app/contenttypes/tests/test_folder.py M plone/app/contenttypes/tests/test_migration.py M plone/app/contenttypes/tests/test_migration_topic.py M plone/app/contenttypes/upgrades.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T16:00:44+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@e254cfd upgrade step Conflicts: plone/app/contenttypes/upgrades.py plone/app/contenttypes/upgrades.zcml Files changed: M plone/app/contenttypes/profiles/default/metadata.xml M plone/app/contenttypes/upgrades.py M plone/app/contenttypes/upgrades.zcml Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T16:00:54+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@c2e4a90 better-to-distinguish name for these tests Files changed: M plone/app/contenttypes/tests/test_behaviors_collection.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T16:01:02+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@af9bf1b views need the plone_view Files changed: M plone/app/contenttypes/browser/templates/full_view_item.pt Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-26T16:09:03+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@bbcf757 old view titles Files changed: M plone/app/contenttypes/browser/configure.zcml Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-27T04:36:04+01:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.app.contenttypes@25c3d3a exclude random image in photoAlbumFolder from robot-test Files changed: M plone/app/contenttypes/tests/robot/test_folderlisting.robot Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-27T04:36:12+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@0803f88 add Plone Site and configure new view names for it Files changed: A plone/app/contenttypes/profiles/default/types/Plone_Site.xml A plone/app/contenttypes/profiles/uninstall/types/Plone_Site.xml M plone/app/contenttypes/profiles/default/types.xml M plone/app/contenttypes/profiles/uninstall/types.xml Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-02-27T04:36:21+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@b85eb2f When installing the default profile, restrict uninstalling of old types to old FTI based ones. Files changed: M docs/CHANGES.rst M plone/app/contenttypes/profiles/default/types.xml Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-03-05T00:53:09+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@cf91ef1 For the link_redirect_view, don't modify the urls for mailto:, tel:, callto: and file: link types but render them as-is. Files changed: M docs/CHANGES.rst M plone/app/contenttypes/browser/link_redirect_view.py M plone/app/contenttypes/tests/test_link.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-03-05T11:03:15+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@5613043 Improve handling of Link types with other URL schemes than http:// and https://. Files changed: M docs/CHANGES.rst M plone/app/contenttypes/browser/link_redirect_view.py M plone/app/contenttypes/tests/test_link.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-03-08T01:18:56+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@d19b9a6 optimize album_view for better performance Files changed: M plone/app/contenttypes/browser/collection.py M plone/app/contenttypes/browser/folder.py M plone/app/contenttypes/browser/templates/listing_album.pt Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-03-08T02:16:21+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@dcea988 bugfix Files changed: M plone/app/contenttypes/browser/collection.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-03-11T03:32:48+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@e831bcc Don't try to show IContentLeadImage images, if theree none. Use the 'mini' scale as default scale for IContentLeadImage Files changed: M docs/CHANGES.rst M plone/app/contenttypes/behaviors/leadimage.pt Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-03-13T09:53:21+01:00 Author: Johannes Raggam (thet) <raggam-nl@adm.at> Commit: plone/plone.app.contenttypes@75a6f3a In the listing view, don't repeat on the article tag, which makes it impossible to override this structure. Instead, repeat on a unrendered tal tag and move the article tag within. Files changed: M docs/CHANGES.rst M plone/app/contenttypes/browser/folder.py M plone/app/contenttypes/browser/templates/listing.pt M plone/app/contenttypes/browser/templates/listing_summary.pt Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-03-29T22:48:23+02:00 Author: Timo Stollenwerk (tisto) <tisto@plone.org> Commit: plone/plone.app.contenttypes@635569e ReSt fix. Files changed: M setup.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-03-29T22:49:07+02:00 Author: Fulvio Casali (fulv) <fulviocasali@gmail.com> Commit: plone/plone.app.contenttypes@177c789 Update image_view_fullscreen.pt for mobile friendliness see plone/Products.CMFPlone#407 Google complains loudly about this template, and will deduct mobile karma points. Also, using a different `viewport` meta directive than sunburst's default, for better accessibility. See: plone/Products.CMFPlone#389 Files changed: M plone/app/contenttypes/browser/templates/image_view_fullscreen.pt Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-03-29T22:50:45+02:00 Author: Fulvio Casali (fulv) <fulviocasali@gmail.com> Commit: plone/plone.app.contenttypes@1378ad3 Add changelog entry Conflicts: docs/CHANGES.rst Files changed: M docs/CHANGES.rst Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-04-07T10:33:34+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.app.contenttypes@73a2184 fix test by publishing links before accessing as anonymous Files changed: M plone/app/contenttypes/tests/test_link.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-04-07T15:03:51+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.app.contenttypes@2744223 fix test of album_view (was testing if doc1 appeared in navigation-portlet) Files changed: M plone/app/contenttypes/tests/test_folder.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-04-07T15:27:27+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.app.contenttypes@0d785c1 Merge branch '1.1.x' into 1.1.x-thet-unifiedlistings Files changed: Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-04-07T15:30:01+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.app.contenttypes@2fbf180 fix flake8 Files changed: M plone/app/contenttypes/behaviors/collection.py M plone/app/contenttypes/browser/collection.py Repository: plone.app.contenttypes Branch: refs/heads/1.1.x Date: 2015-04-07T15:46:11+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.app.contenttypes@80e7237 Merge pull request #216 from plone/1.1.x-thet-unifiedlistings 1.1.x thet unifiedlistings Files changed: A plone/app/contenttypes/browser/templates/listing_album.pt A plone/app/contenttypes/profiles/default/types/Plone_Site.xml A plone/app/contenttypes/profiles/uninstall/types/Plone_Site.xml M buildout.d/checkouts.cfg M buildout.d/sources.cfg M docs/CHANGES.rst M plone/app/contenttypes/behaviors/collection.py M plone/app/contenttypes/behaviors/leadimage.pt M plone/app/contenttypes/browser/collection.py M plone/app/contenttypes/browser/configure.zcml M plone/app/contenttypes/browser/folder.py M plone/app/contenttypes/browser/link_redirect_view.py M plone/app/contenttypes/browser/templates/archetypes_warning_viewlet.pt M plone/app/contenttypes/browser/templates/document.pt M plone/app/contenttypes/browser/templates/file.pt M plone/app/contenttypes/browser/templates/full_view.pt M plone/app/contenttypes/browser/templates/full_view_item.pt M plone/app/contenttypes/browser/templates/image.pt M plone/app/contenttypes/browser/templates/image_view_fullscreen.pt M plone/app/contenttypes/browser/templates/link.pt M plone/app/contenttypes/browser/templates/listing.pt M plone/app/contenttypes/browser/templates/listing_summary.pt M plone/app/contenttypes/browser/templates/listing_tabular.pt M plone/app/contenttypes/browser/templates/newsitem.pt M plone/app/contenttypes/migration/migration.py M plone/app/contenttypes/migration/topics.py M plone/app/contenttypes/profiles/default/metadata.xml M plone/app/contenttypes/profiles/default/types.xml M plone/app/contenttypes/profiles/default/types/Collection.xml M plone/app/contenttypes/profiles/default/types/Folder.xml M plone/app/contenttypes/profiles/uninstall/types.xml M plone/app/contenttypes/tests/robot/test_folderlisting.robot M plone/app/contenttypes/tests/robot/variables.py M plone/app/contenttypes/tests/test_behaviors_collection.py M plone/app/contenttypes/tests/test_collection.py M plone/app/contenttypes/tests/test_folder.py M plone/app/contenttypes/tests/test_link.py M plone/app/contenttypes/tests/test_migration.py M plone/app/contenttypes/tests/test_migration_topic.py M plone/app/contenttypes/upgrades.py M plone/app/contenttypes/upgrades.zcml M setup.py D plone/app/contenttypes/browser/album_view.py D plone/app/contenttypes/browser/templates/folder_album_view.pt D plone/app/contenttypes/browser/templates/thumbnail_view.pt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google complains loudly about this template, and will deduct mobile karma points.