If an object is renamed. There is actually no traking if it is a default... - #69
Conversation
There was a problem hiding this comment.
Can we fix the getDefaultPage method of the portal object instead of adding this special case?
There was a problem hiding this comment.
How should this be possible?
I think the wrong value has to be changed. If it is renamed you will no longer know wich is the new id. Currently the selected view will fall back to folder_listing if the default page is not accessible.
I think this is bad usability.
There was a problem hiding this comment.
I didn't make myself clear. I agree with your pull request as a whole. But I think it could be improved by removing lines 1331-1333 and instead make sure the portal root's getDefaultPage method will look at portal.getProperty('default_page', '')
There was a problem hiding this comment.
Ah ok now i get it. I will take a look on it on monday what the Problem could be
|
Please add a changelog entry. |
…use the page was renamed before.
|
IMO this is a good tiny improvement. It is needed for 5.0 as well. Would be nice to have a test. |
|
@hoka whats the state here? |
|
This could use a test. |
|
I implemented this for Plone 5 in plone/plone.app.content#24 |
If an object is renamed. There is actually no traking if it is a default...
Correctly select tab in GlobalSectionsViewlet
6 participants
... page.
Hi,
here a little usability improvement.
If a default page is renamed, now the relation to the parend is fixed.