Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an object is renamed. There is actually no traking if it is a default... #69

Merged
merged 2 commits into from Jan 24, 2015

Conversation

hoka
Copy link

@hoka hoka commented Oct 1, 2013

... page.

Hi,

here a little usability improvement.

If a default page is renamed, now the relation to the parend is fixed.

if hasattr(parent, 'getDefaultPage'):
default_page = parent.getDefaultPage()

#Plone site has a default_page but return value is None
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the getDefaultPage method of the portal object instead of adding this special case?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should this be possible?
I think the wrong value has to be changed. If it is renamed you will no longer know wich is the new id. Currently the selected view will fall back to folder_listing if the default page is not accessible.
I think this is bad usability.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't make myself clear. I agree with your pull request as a whole. But I think it could be improved by removing lines 1331-1333 and instead make sure the portal root's getDefaultPage method will look at portal.getProperty('default_page', '')

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok now i get it. I will take a look on it on monday what the Problem could be

@davisagli
Copy link
Sponsor Member

Please add a changelog entry.

@davisagli davisagli mentioned this pull request Feb 25, 2014
90 tasks
@jensens
Copy link
Sponsor Member

jensens commented Apr 3, 2014

IMO this is a good tiny improvement. It is needed for 5.0 as well. Would be nice to have a test.

@jensens
Copy link
Sponsor Member

jensens commented Jun 16, 2014

@hoka whats the state here?

@jaroel
Copy link
Member

jaroel commented Jul 4, 2014

This could use a test.
Shouldn't this also go into master?

@pbauer
Copy link
Sponsor Member

pbauer commented Jan 23, 2015

I implemented this for Plone 5 in plone/plone.app.content#24

jensens added a commit that referenced this pull request Jan 24, 2015
If an object is renamed. There is actually no traking if it is a default...
@jensens jensens merged commit eca5dd2 into plone:4.3.x Jan 24, 2015
jensens added a commit that referenced this pull request Nov 12, 2021
Correctly select tab in GlobalSectionsViewlet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants