New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midsummersprint fix transforms #20

Merged
merged 8 commits into from Jul 28, 2017

Conversation

Projects
None yet
6 participants
@MrTango
Contributor

MrTango commented Jul 6, 2017

No description provided.

Show outdated Hide outdated Products/PortalTransforms/tests/test_transforms.py
@@ -415,7 +440,7 @@ def make_tests(test_descr=TRANSFORMS_TESTINFO):
except MissingBinary:
# we are not interessted in tests with missing binaries
continue
except:
except: # noqa

This comment has been minimized.

@gforcada

gforcada Jul 6, 2017

Contributor

Rather than a # noqa you can add except Exception:

@gforcada

gforcada Jul 6, 2017

Contributor

Rather than a # noqa you can add except Exception:

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Jul 6, 2017

Contributor

Thanks for porting it over to plone.app.testing!!

Contributor

gforcada commented Jul 6, 2017

Thanks for porting it over to plone.app.testing!!

@tisto tisto self-requested a review Jul 7, 2017

@tisto

tisto approved these changes Jul 7, 2017

Show outdated Hide outdated Products/PortalTransforms/tests/test_transforms.py
@@ -201,6 +201,20 @@ def setUp(self):
registry = getUtility(IRegistry)
self.settings = registry.forInterface(
IFilterSchema, prefix="plone")
self.settings.valid_tags.append('style')
import transaction
transaction.commit()

This comment has been minimized.

@gforcada

gforcada Jul 7, 2017

Contributor

@MrTango if you make manual commits you need to switch from integration to functional layer, if not we will have test isolation problems later on

@gforcada

gforcada Jul 7, 2017

Contributor

@MrTango if you make manual commits you need to switch from integration to functional layer, if not we will have test isolation problems later on

MrTango added some commits Jul 7, 2017

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Jul 13, 2017

Contributor

@MrTango I removed the transaction.commit (at least locally the tests continued to pass without it), so we don't need to move the test to a functional layer.

Contributor

gforcada commented Jul 13, 2017

@MrTango I removed the transaction.commit (at least locally the tests continued to pass without it), so we don't need to move the test to a functional layer.

@agitator agitator merged commit fda4e13 into master Jul 28, 2017

3 checks passed

Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.1 Job finished with success status
Details

@agitator agitator deleted the midsummersprint_fix_transforms branch Jul 28, 2017

@pbauer

This comment has been minimized.

Show comment
Hide comment
@pbauer

pbauer Aug 28, 2017

Member

The upgrade-step for this change is in plone/plone.app.upgrade@60d6c49

Member

pbauer commented Aug 28, 2017

The upgrade-step for this change is in plone/plone.app.upgrade@60d6c49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment