New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip data URIs when making URLs absolute #16

Merged
merged 1 commit into from Jun 16, 2014

Conversation

Projects
None yet
3 participants
@cillianderoiste
Contributor

cillianderoiste commented Mar 14, 2014

Currently, applyPrefix will convert URIs such as
url(data:image/svg+xml;base64,PD94bWwgdmVyc2lv) to absolute urls. This
patch uses (?!data:) to fail the RegEx match where the URI starts with
"data:"

Skip data URIs when making URLs absolute
Currently, applyPrefix will convert URIs such as
url(data:image/svg+xml;base64,PD94bWwgdmVyc2lv) to absolute urls. This
patch uses (?!data:) to fail the RegEx match where the URI starts with
"data:"
@davisagli

This comment has been minimized.

Show comment
Hide comment
@davisagli

davisagli Mar 25, 2014

Member

Please add a changelog entry

Member

davisagli commented Mar 25, 2014

Please add a changelog entry

@cillianderoiste cillianderoiste self-assigned this Apr 22, 2014

jensens added a commit that referenced this pull request Jun 16, 2014

Merge pull request #16 from syslabcom/master
Skip data URIs when making URLs absolute

@jensens jensens merged commit ee9d5b2 into plone:master Jun 16, 2014

jensens added a commit that referenced this pull request Jun 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment