Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

filter inline data from images before storing #39

Merged
merged 1 commit into from Dec 18, 2012

Conversation

Projects
None yet
3 participants
Member

khink commented Nov 16, 2012

Fixes https://dev.plone.org/ticket/13199 for Plone 4.2.x

Contributor

garbas commented Dec 17, 2012

@khink you still care to get this into 1.2.x? if so i think if you update your pull request we can get it into nex plone 4.2 release which is going to happen verry soon

Member

khink commented Dec 17, 2012

@garbas Thanks for the hint! I rebased and had to do a push -f. So the commit looks new, but it's the same one.

Owner

davisagli commented Dec 17, 2012

@khink in the future please don't rebase and force-push commits that you've already posted publicly. You can merge instead. Thanks!

garbas added a commit that referenced this pull request Dec 18, 2012

Merge pull request #39 from khink/khink-filter-data-images-13199
filter inline data from images before storing

@garbas garbas merged commit 41d3ae0 into plone:1.2.x Dec 18, 2012

Contributor

garbas commented Dec 18, 2012

@khink merged, tnx
@davisagli isnt it ok to rebase on top of public work? @khink is pushing from his own account not code that is in plone organization. or am i misunderstanding something (again:P)?

Owner

davisagli commented Dec 18, 2012

It's less of a problem if it's in his own organization, but I still think it's considerate to avoid rebase once there's any chance that someone else has found the branch and based their own fork on it.

Member

khink commented Dec 19, 2012

PS @davisagli : Thanks, will do.

@khink khink deleted the khink:khink-filter-data-images-13199 branch Mar 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment