Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonschemavalidation #517

Closed
wants to merge 7 commits into from

Conversation

@karannaoh
Copy link
Member

commented Jun 1, 2019

No description provided.

@karannaoh karannaoh requested review from bloodbare and vangheem as code owners Jun 1, 2019
@karannaoh karannaoh force-pushed the jsonschemavalidation branch 2 times, most recently from 9eb4895 to a94137e Jun 5, 2019
@karannaoh karannaoh force-pushed the jsonschemavalidation branch from a94137e to 398de96 Jun 5, 2019
karannaoh added 2 commits Jun 5, 2019
@karannaoh karannaoh force-pushed the jsonschemavalidation branch from 9783272 to 459c25d Jun 6, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jun 6, 2019

Codecov Report

Merging #517 into master will decrease coverage by 0.02%.
The diff coverage is 89.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   94.15%   94.12%   -0.03%     
==========================================
  Files         250      250              
  Lines       22332    22404      +72     
==========================================
+ Hits        21026    21088      +62     
- Misses       1306     1316      +10
Impacted Files Coverage Δ
guillotina/json/definitions.py 100% <100%> (ø) ⬆️
guillotina/tests/test_api.py 99.25% <100%> (+0.02%) ⬆️
guillotina/api/addons.py 100% <100%> (ø) ⬆️
guillotina/api/content.py 87.71% <72.72%> (-0.35%) ⬇️
guillotina/api/registry.py 82.35% <82.14%> (-1.74%) ⬇️
guillotina/api/behaviors.py 95% <87.09%> (-5%) ⬇️
guillotina/api/container.py 95.45% <90.9%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b433e...71f7c01. Read the comment docs.

@karannaoh karannaoh closed this Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.