Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor read conn to exclusively be for operations and not initialization #739

Merged
merged 12 commits into from Nov 22, 2019

Conversation

@vangheem
Copy link
Member

vangheem commented Nov 21, 2019

No description provided.

@vangheem vangheem requested review from bloodbare and masipcat as code owners Nov 21, 2019
@masipcat

This comment has been minimized.

Copy link
Contributor

masipcat commented Nov 21, 2019

If I'm not getting it wrong, the read_conn is only used during initialization (in storage._initialize_tid_statements() and storage.create()), right? In that case, whats the purpose of keeping this connection open?

@vangheem

This comment has been minimized.

Copy link
Member Author

vangheem commented Nov 21, 2019

It's used to get the current tid of a transaction and check conflicts as well.

Copy link
Member

bloodbare left a comment

I'll be able to review properly later today

vangheem added 3 commits Nov 21, 2019
fix
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #739 into master will increase coverage by 0.1%.
The diff coverage is 94.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #739     +/-   ##
========================================
+ Coverage      94%     94%   +0.1%     
========================================
  Files         305     305             
  Lines       26833   26854     +21     
========================================
+ Hits        25214   25239     +25     
+ Misses       1619    1615      -4
Impacted Files Coverage Δ
guillotina/tests/fixtures.py 94.4% <100%> (+1.4%) ⬆️
guillotina/db/events.py 100% <100%> (ø) ⬆️
guillotina/db/storages/cockroach.py 76% <100%> (+0.6%) ⬆️
guillotina/tests/test_postgres.py 100% <100%> (ø) ⬆️
guillotina/migrations/__init__.py 88.9% <81.9%> (+7.7%) ⬆️
guillotina/db/storages/pg.py 89.4% <95.9%> (+0.1%) ⬆️
vangheem added 4 commits Nov 21, 2019
fix
fix
@vangheem

This comment has been minimized.

Copy link
Member Author

vangheem commented Nov 21, 2019

@bloodbare it's ready for final review

vangheem added 3 commits Nov 21, 2019
Copy link
Member

bloodbare left a comment

lgtm

@vangheem vangheem merged commit 19ef28c into master Nov 22, 2019
5 checks passed
5 checks passed
Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
codecov/patch 94.6% of diff hit (target 94%)
Details
codecov/project 94% (+0.1%) compared to 2ed25be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vangheem vangheem deleted the deadlocks branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.