New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to test multiple pull requests. #126

Closed
tisto opened this Issue Sep 7, 2015 · 10 comments

Comments

Projects
None yet
5 participants
@tisto
Member

tisto commented Sep 7, 2015

We could extend the pull request jobs to allow to paste multiple pull request URLs. Right now we have to create a PLIP job for those kind of pull requests. It shouldn't be too hard to test multiple checkouts instead of just one. Any takes?

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Sep 7, 2015

Contributor

So basically adding a loop on https://github.com/plone/jenkins.plone.org/blob/master/jobs.yml#L743-L757 ?

That seems easy, OTOH a PLIP job ensures that other developers can check that code as well, not just you and jenkins (provided you give to it all the pull requests)

Contributor

gforcada commented Sep 7, 2015

So basically adding a loop on https://github.com/plone/jenkins.plone.org/blob/master/jobs.yml#L743-L757 ?

That seems easy, OTOH a PLIP job ensures that other developers can check that code as well, not just you and jenkins (provided you give to it all the pull requests)

@tisto

This comment has been minimized.

Show comment
Hide comment
@tisto

tisto Sep 7, 2015

Member

Yes. That was my idea. We can still use the PLIP job for more complex
use cases. Sometimes the PLIP job is just overkill though.

Am 07.09.2015 um 13:40 schrieb Gil Forcada Codinachs:

So basically adding a loop on
https://github.com/plone/jenkins.plone.org/blob/master/jobs.yml#L743-L757 ?

That seems easy, OTOH a PLIP job ensures that other developers can check
that code as well, not just you and jenkins (provided you give to it all
the pull requests)


Reply to this email directly or view it on GitHub
#126 (comment).

Member

tisto commented Sep 7, 2015

Yes. That was my idea. We can still use the PLIP job for more complex
use cases. Sometimes the PLIP job is just overkill though.

Am 07.09.2015 um 13:40 schrieb Gil Forcada Codinachs:

So basically adding a loop on
https://github.com/plone/jenkins.plone.org/blob/master/jobs.yml#L743-L757 ?

That seems easy, OTOH a PLIP job ensures that other developers can check
that code as well, not just you and jenkins (provided you give to it all
the pull requests)


Reply to this email directly or view it on GitHub
#126 (comment).

@jensens

This comment has been minimized.

Show comment
Hide comment
@jensens

jensens Sep 28, 2015

Member

big 👍 for the feature

Member

jensens commented Sep 28, 2015

big 👍 for the feature

@mauritsvanrees

This comment has been minimized.

Show comment
Hide comment
@mauritsvanrees

mauritsvanrees Oct 29, 2015

Member

Sounds elegant.

Member

mauritsvanrees commented Oct 29, 2015

Sounds elegant.

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Oct 30, 2015

Contributor

I'm running a jenkins job with two pull requests on it: http://jenkins.plone.org/view/All/job/pull-request-5.0/519/console :-)

Once that shows green I will push the code and close this issue.

Contributor

gforcada commented Oct 30, 2015

I'm running a jenkins job with two pull requests on it: http://jenkins.plone.org/view/All/job/pull-request-5.0/519/console :-)

Once that shows green I will push the code and close this issue.

@gforcada gforcada closed this in 4ba1250 Oct 30, 2015

@jensens

This comment has been minimized.

Show comment
Hide comment
@jensens

jensens Oct 30, 2015

Member

yeah!

Member

jensens commented Oct 30, 2015

yeah!

@tisto

This comment has been minimized.

Show comment
Hide comment
@tisto

tisto Oct 30, 2015

Member

AWESOME!!! Thanks @gforcada!

Member

tisto commented Oct 30, 2015

AWESOME!!! Thanks @gforcada!

@davisagli

This comment has been minimized.

Show comment
Hide comment
@davisagli

davisagli Oct 30, 2015

Member

@gforcada your blog post says to let you know if this does not work as expected. Well, I'm not quite sure what to expect. Just put each pull request URL on a separate line? Where's the documentation?

Member

davisagli commented Oct 30, 2015

@gforcada your blog post says to let you know if this does not work as expected. Well, I'm not quite sure what to expect. Just put each pull request URL on a separate line? Where's the documentation?

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Oct 30, 2015

Contributor

@davisagli yes, one per line, and thanks for the reminder, I actually added it here: http://jenkins.plone.org/job/pull-request-5.0/build but forget the push the changes to jenkins. Now it should be shown there.

Contributor

gforcada commented Oct 30, 2015

@davisagli yes, one per line, and thanks for the reminder, I actually added it here: http://jenkins.plone.org/job/pull-request-5.0/build but forget the push the changes to jenkins. Now it should be shown there.

@davisagli

This comment has been minimized.

Show comment
Hide comment
@davisagli

davisagli Oct 30, 2015

Member

@gforcada good, thanks!

Member

davisagli commented Oct 30, 2015

@gforcada good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment