Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add content icon to relateditems pattern #465

Merged
merged 3 commits into from Feb 23, 2015
Merged

add content icon to relateditems pattern #465

merged 3 commits into from Feb 23, 2015

Conversation

petschki
Copy link
Member

see #442

@vangheem
Copy link
Member

How does this work OOTB? Does plone give a meaningful value for getIcon all the time. Should those img tags be conditionally in the template?

@davisagli
Copy link
Sponsor Member

It only returns a value for types that have an icon_expr set in portal_types. Most of the core types don't have an icon there (they get icons via CSS) but some addons still do. In plone.app.contenttypes file and image have a special getIcon indexer which gets an icon from the mimetypes_registry based on the file mimetype

@petschki
Copy link
Member Author

So this is what the latest change brings OOTB:
bildschirmfoto 2015-02-23 um 10 30 13

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.2% when pulling 7875a3e on issue-442 into 0478aff on master.

@vangheem
Copy link
Member

I'm okay with this. This way you can have customized icons thumbnails and icons are the fallback.

Side note: We should match the icons used in Plone 5(defined as only css rules) back into the filesystem icon image files defined.

vangheem added a commit that referenced this pull request Feb 23, 2015
add content icon to relateditems pattern
@vangheem vangheem merged commit 39c1fb5 into master Feb 23, 2015
@vangheem vangheem deleted the issue-442 branch February 23, 2015 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants