mimetype can't be None and always use filename if available #8

Merged
merged 1 commit into from Sep 13, 2013

Projects

None yet

4 participants

@tschanzt
Contributor

I tried to eliminate the possibility of the mimetype being none, since it isn't a correct mimetype and will raise an error every time you try to access the mimetype of this file.
Also it is now possible to use the filename if the value is a string. So we can find the mimetype based on the extension and not only with the magic bytes so we can distinguish more contenttypes.

@vangheem vangheem merged commit d155ce2 into master Sep 13, 2013
@mister-roboto

Testing information:

@vangheem
Member

want to add this to the changelog?

@tschanzt
Contributor

@vangheem I did or is there another one I didn't see?

@vangheem
Member

oh, ignore me, I'm blind. Thanks!

@davisagli
Member

Looks like this broke several tests in Products.ATContentTypes: http://jenkins.plone.org/job/plone-4.3-python-2.6/1415/

Please fix that or revert the change.

@jensens jensens deleted the tt-mimetypes branch Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment