Cleanup #83

Merged
merged 1 commit into from Feb 5, 2016

Conversation

Projects
None yet
2 participants
@jenkins-plone-org

This comment has been minimized.

Show comment
Hide comment
@jenkins-plone-org

jenkins-plone-org Feb 5, 2016

@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/26//violations

plone/app/discussion/contentrules.py:20:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/browser/comments.py:132:1: C901 'CommentForm.handleComment' is too complex (17)
plone/app/discussion/browser/conversation.py:29:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:135:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/migration.py:34:1: C901 'View.__call__' is too complex (32)

Follow these instructions to reproduce it locally.

@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/26//violations

plone/app/discussion/contentrules.py:20:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/browser/comments.py:132:1: C901 'CommentForm.handleComment' is too complex (17)
plone/app/discussion/browser/conversation.py:29:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:135:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/migration.py:34:1: C901 'View.__call__' is too complex (32)

Follow these instructions to reproduce it locally.

gforcada added a commit that referenced this pull request Feb 5, 2016

@gforcada gforcada merged commit f0d8372 into master Feb 5, 2016

1 check passed

Plone Jenkins CI - pull-request-5.0 Job finished with success status
Details

@gforcada gforcada deleted the cleanup branch Feb 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment