New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that draft target is acquisition wrapped #6

Merged
merged 5 commits into from Jul 3, 2017

Conversation

Projects
None yet
3 participants
@datakurre
Member

datakurre commented Jul 3, 2017

datakurre added some commits Jul 3, 2017

@jenkins-plone-org

This comment has been minimized.

Show comment
Hide comment
@jenkins-plone-org

jenkins-plone-org Jul 3, 2017

@datakurre Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.drafts/2/violations

plone/app/drafts/storage.py:44:30: Q000 Remove bad quotes.
plone/app/drafts/storage.py:48:19: Q000 Remove bad quotes.
plone/app/drafts/storage.py:50:30: Q000 Remove bad quotes.
plone/app/drafts/tests.py:1222:13: P101 format string does contain unindexed parameters
plone/app/drafts/testing.py:117:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/drafts/interfaces.py:20:42: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:21:45: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:22:38: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:32:15: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:37:15: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:38:21: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:39:40: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:41:44: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:43:52: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:150:36: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:151:39: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:152:39: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:154:15: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:156:15: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:159:15: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:160:21: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:161:9: Q000 Remove bad quotes.
plone/app/drafts/__init__.py:7:1: I001 isort found an import in the wrong position

Follow these instructions to reproduce it locally.

jenkins-plone-org commented on d25e21e Jul 3, 2017

@datakurre Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.drafts/2/violations

plone/app/drafts/storage.py:44:30: Q000 Remove bad quotes.
plone/app/drafts/storage.py:48:19: Q000 Remove bad quotes.
plone/app/drafts/storage.py:50:30: Q000 Remove bad quotes.
plone/app/drafts/tests.py:1222:13: P101 format string does contain unindexed parameters
plone/app/drafts/testing.py:117:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/drafts/interfaces.py:20:42: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:21:45: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:22:38: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:32:15: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:37:15: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:38:21: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:39:40: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:41:44: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:43:52: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:150:36: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:151:39: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:152:39: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:154:15: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:156:15: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:159:15: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:160:21: Q000 Remove bad quotes.
plone/app/drafts/interfaces.py:161:9: Q000 Remove bad quotes.
plone/app/drafts/__init__.py:7:1: I001 isort found an import in the wrong position

Follow these instructions to reproduce it locally.

datakurre added some commits Jul 3, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 3, 2017

Coverage Status

Coverage decreased (-0.06%) to 88.395% when pulling 87bac70 on datakurre-missing-aq-wrapper into 31188b6 on master.

coveralls commented Jul 3, 2017

Coverage Status

Coverage decreased (-0.06%) to 88.395% when pulling 87bac70 on datakurre-missing-aq-wrapper into 31188b6 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 3, 2017

Coverage Status

Coverage decreased (-0.06%) to 88.395% when pulling 87bac70 on datakurre-missing-aq-wrapper into 31188b6 on master.

coveralls commented Jul 3, 2017

Coverage Status

Coverage decreased (-0.06%) to 88.395% when pulling 87bac70 on datakurre-missing-aq-wrapper into 31188b6 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 3, 2017

Coverage Status

Coverage decreased (-0.06%) to 88.395% when pulling 87bac70 on datakurre-missing-aq-wrapper into 31188b6 on master.

coveralls commented Jul 3, 2017

Coverage Status

Coverage decreased (-0.06%) to 88.395% when pulling 87bac70 on datakurre-missing-aq-wrapper into 31188b6 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 3, 2017

Coverage Status

Coverage increased (+1.7%) to 90.172% when pulling c19ef7f on datakurre-missing-aq-wrapper into 31188b6 on master.

coveralls commented Jul 3, 2017

Coverage Status

Coverage increased (+1.7%) to 90.172% when pulling c19ef7f on datakurre-missing-aq-wrapper into 31188b6 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 3, 2017

Coverage Status

Coverage increased (+2.2%) to 90.633% when pulling 34d80e3 on datakurre-missing-aq-wrapper into 31188b6 on master.

coveralls commented Jul 3, 2017

Coverage Status

Coverage increased (+2.2%) to 90.633% when pulling 34d80e3 on datakurre-missing-aq-wrapper into 31188b6 on master.

@datakurre datakurre merged commit 189ea1b into master Jul 3, 2017

5 checks passed

Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.5%) to 90.633%
Details

@datakurre datakurre deleted the datakurre-missing-aq-wrapper branch Jul 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment