New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename media to assets #284

Merged
merged 3 commits into from Jul 9, 2017

Conversation

Projects
None yet
3 participants
@agitator
Member

agitator commented Jul 5, 2017

closes #280

@agitator agitator requested a review from datakurre Jul 5, 2017

@datakurre

This comment has been minimized.

Show comment
Hide comment
@datakurre

datakurre Jul 6, 2017

Member

Changing the default name of media folder into "assets" is ok for me.

@jensens @thet Any objections?

Member

datakurre commented Jul 6, 2017

Changing the default name of media folder into "assets" is ok for me.

@jensens @thet Any objections?

@erral

This comment has been minimized.

Show comment
Hide comment
@erral

erral Jul 6, 2017

Member

Will this break existing sites that upgrade to the new version of p.a.m?

I see that the subscriber that takes care of the LIF doesn't make any assumption on the id of the folder, but just to be sure...

Member

erral commented Jul 6, 2017

Will this break existing sites that upgrade to the new version of p.a.m?

I see that the subscriber that takes care of the LIF doesn't make any assumption on the id of the folder, but just to be sure...

@erral

This comment has been minimized.

Show comment
Hide comment
@erral

erral Jul 6, 2017

Member

Moreover, I think that we should i18nize the title "Assets" for the folder. While "Media" could be understood in all languages, "Assets" is not and I think it requires a proper msgid in the po files.

Member

erral commented Jul 6, 2017

Moreover, I think that we should i18nize the title "Assets" for the folder. While "Media" could be understood in all languages, "Assets" is not and I think it requires a proper msgid in the po files.

@datakurre

This comment has been minimized.

Show comment
Hide comment
@datakurre

datakurre Jul 6, 2017

Member

@erral Thanks for noticing that assets is not as "universal" as "media". I try to convince @agitator to i18nize it.

And correct, id can be anything and the default id and title only affect the new folders. LIF folders can also be renamed manually, but it requires making them implicitly addable at first.

Member

datakurre commented Jul 6, 2017

@erral Thanks for noticing that assets is not as "universal" as "media". I try to convince @agitator to i18nize it.

And correct, id can be anything and the default id and title only affect the new folders. LIF folders can also be renamed manually, but it requires making them implicitly addable at first.

@datakurre

I've now i18nized "assets" folder id and title.

@datakurre

This comment has been minimized.

Show comment
Hide comment
@datakurre

datakurre Jul 6, 2017

Member

FYI. I did not touch translate menu here. After this has been approved, I submit a comprehensive refactoring for the translate menu contents.

Member

datakurre commented Jul 6, 2017

FYI. I did not touch translate menu here. After this has been approved, I submit a comprehensive refactoring for the translate menu contents.

@datakurre

This comment has been minimized.

Show comment
Hide comment
@datakurre

datakurre Jul 9, 2017

Member

I assume this is ok now.

Member

datakurre commented Jul 9, 2017

I assume this is ok now.

@datakurre datakurre merged commit c11bf68 into master Jul 9, 2017

4 checks passed

Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.0 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.1 Job finished with success status
Details

@datakurre datakurre deleted the rename_media_to_assets branch Jul 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment