New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor translation menu #285

Merged
merged 3 commits into from Jul 18, 2017

Conversation

Projects
None yet
4 participants
@datakurre
Member

datakurre commented Jul 7, 2017

  • When viewing a folder with a default page, the translation menu shows all
    options for both the folder and then the default page in the
    same order and with the same titles. The option to edit the current page in
    babel view have been merged with the options to edit the other translations
    to make the menu more consistent

  • Translation menu show the title of the language independent folder on
    the language independent folder link in translation menu as
    "Open ${title} folder"

  • Translation menu no longer includes "Set content language"-menuitem, which
    was redundant (but less transparent in its behavior) to just cutting and
    pasting a content under the desired language folder

Before:

the collection english 1

After:

the collection english

@datakurre datakurre requested a review from agitator Jul 7, 2017

@datakurre

This comment has been minimized.

Show comment
Hide comment
@datakurre

datakurre Jul 7, 2017

Member

@agitator Do you think, "Folder translation" and "Item translation" messages should be in plural? Asking before change, because it would require you to update de-localization again.

Member

datakurre commented Jul 7, 2017

@agitator Do you think, "Folder translation" and "Item translation" messages should be in plural? Asking before change, because it would require you to update de-localization again.

@thet

This comment has been minimized.

Show comment
Hide comment
@thet

thet Jul 7, 2017

Member

@datakurre I think it's perfectly fine to have "Folder translation" and "Item translation" in singular.

Member

thet commented Jul 7, 2017

@datakurre I think it's perfectly fine to have "Folder translation" and "Item translation" in singular.

@agitator

This comment has been minimized.

Show comment
Hide comment
@agitator

agitator Jul 7, 2017

Member

I'd also say singular, most of the actions effect a single item

Member

agitator commented Jul 7, 2017

I'd also say singular, most of the actions effect a single item

@agitator

This comment has been minimized.

Show comment
Hide comment
@agitator

agitator Jul 18, 2017

Member

@datakurre what's missing for a merge? me wants this in a client project ;-)

Member

agitator commented Jul 18, 2017

@datakurre what's missing for a merge? me wants this in a client project ;-)

@datakurre

This comment has been minimized.

Show comment
Hide comment
@datakurre

datakurre Jul 18, 2017

Member

It's ready! I am missing. :)

Member

datakurre commented Jul 18, 2017

It's ready! I am missing. :)

@jensens jensens merged commit feb2dba into master Jul 18, 2017

4 checks passed

Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.0 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.1 Job finished with success status
Details

@jensens jensens deleted the datakurre-translation-menu branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment