Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Portlet not working with Plone 5.2 #132

Open
mamoep opened this issue Sep 5, 2019 · 3 comments

Comments

@mamoep
Copy link

commented Sep 5, 2019

What steps reproduce the problem?

  1. install Plone 5.2 via unified installer
  2. login to the Zope interface and deploy a new plone site from Zope
  3. add the login portlet to the default front page
  4. logout of Zope and close the browser
  5. Start new incognito browser sesseion and use the login portlet to login with the default admin credentials created via buildout

What do you expect when you do that?
Successful login

What happens instead?
Login fails but I see the toolbar. Refreshing the page and the toolbar is gone again. Trying to click anything on the toolbar and it is gone again.
grafik

Which Plone version are you using?
5.2 on RHEL7

Analysis from Dieter Maurer in the Community Forum:

The bug is understood: Plone is now using z3c.form for login_form. As a consequence, the expected button names have changed and the "login portlet" has not yet been adapted. Concretely: the "login portlet" causes the login button to get name "submit"; login_form, however, expects it to have the name buttons.login. Due to this discrepancy, login_form does not perform the login actions (set the cookie, redirect).

https://community.plone.org/t/plone-5-2-login-portlet-not-working/9050

@jensens

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

I fear we missed the portlet at the time we switched from CMFFormController based login scripts to a z3cform based login process. It looks like it is rarely used since it took a while until you found the bug.

@djay

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

@jensens I fear it means there aren't enough tests :( Maybe newbie sprints to add missing tests? I know for example the theme editor has virtually no tests and that has a long standing bug in 5.2 and was released with that bug.

@jensens

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

@djay there are only some basic unit tests, but nothing is testing the login from the portlet on an UI level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.