Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for Atom feeds without a "siteurl" link. #1

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Member

dokai commented Sep 30, 2011

It is possible for a valid Atom feed to omit a

  <link rel="alternate" type="html" href="http://server.com"/>

element which is available through the feedparser object as a

feed.link

attribute. If the feed does not have this element then the RSS portlet
will throw an AttributeError which will propagate to the page preventing
the original page from rendering.

This changeset adds support for such feeds.

@dokai dokai Don't break if a feed does not have an "rel=alternate type=html" link.
It is possible for a valid Atom feed to omit a

  <link rel="alternate" type="html" href="http://server.com"/>

element which is available through the feedparser object as a

  feed.link

attribute. If the feed does not have this element then the RSS portlet
will throw an AttributeError which will propagate to the page preventing
the original page from rendering.

This changeset adds support for such feeds.
1fc6854
Owner

thet commented Mar 30, 2012

please add a test and update CHANGES.txt accordingly.

@garbas garbas commented on the diff Nov 23, 2012

plone/app/portlets/portlets/rss.py
@@ -161,8 +161,11 @@ def _retrieveFeed(self):
self._failed = True
return False
self._title = d.feed.title
@garbas

garbas Nov 23, 2012

Contributor

same could be done for d.feed.title

Contributor

garbas commented Dec 8, 2012

i've merged this to master manually

@garbas garbas closed this Dec 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment