Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operators selection.any and selection.all to Subject #31

Merged
merged 3 commits into from Jul 17, 2015

Conversation

Projects
None yet
5 participants
@MrTango
Copy link
Contributor

commented Apr 18, 2015

change Subject QueryField operators to use selection.oneOf and selection.all
operators. The change make's it possible to use "oneOf" (OR) and "all" (AND) for
Tag criteria of collections. Now is there only a meaningless "Is" operator.

Add operators selection.oneOf and selection.all
change Subject QueryField operators to use selection.oneOf and selection.all
operators. The change make's it possible to use "oneOf" (OR) and "all" (AND) for
Tag criteria of collections. Now is there only a meaningless "Is" operator.
@gforcada

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2015

@djowett

This comment has been minimized.

Copy link

commented Apr 21, 2015

+1 for this. Strangely I was just looking at the same issue.
I would recommend to change the English slightly as as tags are not really "contained" in an object:

"Contains one of" -> "Matches one of"
"Contains all" -> "Matches all of"

@MrTango

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2015

Your are right. I think i'll spend some time on friday (World Plone Office Day) to finished this and the robot test for plone.app.contenttypes for the collections..

@djowett

This comment has been minimized.

Copy link

commented Apr 22, 2015

Fantastic (and thanks for the reminder)..
I did notice room for more testing while going through the stack for this issue.

@gforcada

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2015

Running it again as the previous run did not take off: http://jenkins.plone.org/job/pull-request/87/console

@jensens

This comment has been minimized.

Copy link
Member

commented Apr 24, 2015

looks like there are some migration issues left, see http://jenkins.plone.org/job/pull-request/87/testReport/

@MrTango

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2015

yes, i'll check fix that soon.

@jensens

This comment has been minimized.

Copy link
Member

commented Apr 27, 2015

and please rebase :)

Merge branch 'master' into mrtango-subject-all-operator
Conflicts:
	plone/app/querystring/profiles.zcml
	plone/app/querystring/profiles/upgrades/to_6/registry.xml
	plone/app/querystring/queryparser.py
	plone/app/querystring/upgrades.zcml
@jensens

This comment has been minimized.

Copy link
Member

commented on a0eff52 Jul 15, 2015

Would be better to use rebase instead of merge, so you dont pull in the whole history of master into your branch

@MrTango MrTango changed the title Add operators selection.oneOf and selection.all Add operators selection.any and selection.all to Subject Jul 17, 2015

@MrTango

This comment has been minimized.

bloodbare added a commit that referenced this pull request Jul 17, 2015

Merge pull request #31 from plone/mrtango-subject-all-operator
Add operators selection.any and selection.all to Subject

@bloodbare bloodbare merged commit 3d08240 into master Jul 17, 2015

@bloodbare bloodbare deleted the mrtango-subject-all-operator branch Jul 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.