New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print ZServer and XMRPC URLs on server startup (Plone 4). #105

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
4 participants
@jone
Copy link
Member

jone commented Feb 8, 2019

When starting the robot server, the ports for the ZServer and for the XMLRPC-server can be configured to 0 in order to let the operating system choose a random open port.

When the ports are randomly chosen, it is helpful that the server prints out the chosen ports in form of URLs, so that a caller may read the URLs in order to connect to the servers.

This is a back port for Plone 4; Plone 5 version: #106

Print ZServer and XMRPC URLs on server startup.
When starting the robot server, the ports for the ZServer and for the
XMLRPC-server can be configured to 0 in order to let the operating
system choose a random open port.

When the ports are randomly chosen, it is helpful that the server
prints out the chosen ports in form of URLs, so that a caller may read
the URLs in order to connect to the servers.
@mister-roboto

This comment has been minimized.

Copy link

mister-roboto commented Feb 8, 2019

@jone thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt

This comment has been minimized.

Copy link
Member

ale-rt commented Feb 8, 2019

Same thing applies #106 (comment)

@ale-rt

ale-rt approved these changes Feb 8, 2019

@gforcada gforcada merged commit 2cf03e3 into 1.2.x Feb 8, 2019

3 checks passed

Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-4.3 Job finished with success status
Details

@gforcada gforcada deleted the jone-print-urls-1.2.x branch Feb 8, 2019

@jone

This comment has been minimized.

Copy link
Member Author

jone commented Feb 11, 2019

@gforcada thanks for merging!
Could you maybe cut a 1.2.x release? This would very helpful since we are still on Plone 4 on this project.

@gforcada

This comment has been minimized.

Copy link
Contributor

gforcada commented Feb 11, 2019

Sure, no problem, I will try to make a release today

@gforcada

This comment has been minimized.

Copy link
Contributor

gforcada commented Feb 11, 2019

@jone and 1.2.3 is out 🎉

@jone

This comment has been minimized.

Copy link
Member Author

jone commented Feb 11, 2019

@gforcada Awesome, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment