New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print ZServer and XMRPC URLs on server startup (Plone 5). #106

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
4 participants
@jone
Copy link
Member

jone commented Feb 8, 2019

When starting the robot server, the ports for the ZServer and for the XMLRPC-server can be configured to 0 in order to let the operating system choose a random open port.

When the ports are randomly chosen, it is helpful that the server prints out the chosen ports in form of URLs, so that a caller may read the URLs in order to connect to the servers.

Back ported to Plone 4: #105

Print ZServer and XMRPC URLs on server startup.
When starting the robot server, the ports for the ZServer and for the
XMLRPC-server can be configured to 0 in order to let the operating
system choose a random open port.

When the ports are randomly chosen, it is helpful that the server
prints out the chosen ports in form of URLs, so that a caller may read
the URLs in order to connect to the servers.
@mister-roboto

This comment has been minimized.

Copy link

mister-roboto commented Feb 8, 2019

@jone thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt

This comment has been minimized.

Copy link
Member

ale-rt commented Feb 8, 2019

It would be nice to also add this to the start_reload function and decorate the message like the other ones.
See:

[ale@emily plone.app.robotframework]$ ./bin/robot-server plone.app.robotframework.testing.PLONE_ROBOT_TESTING 
09:07:07 [ wait ] Starting Zope robot server
Could not install product Products.CMFPlacefulWorkflow
Could not install product plone.app.folder
09:07:14 [ wait ] Watchdog is watching for changes in src
09:07:14 [ wait ] Fork loop now starting on parent process 8163
09:07:14 [ wait ] Fork loop forked a new child process 8190
09:07:14 [ ready ] Zope robot server started
XMLRPC: http://127.0.0.1:49999

Anyway this can be done later.

@ale-rt

ale-rt approved these changes Feb 8, 2019

@gforcada gforcada merged commit 8e64a56 into master Feb 8, 2019

7 checks passed

Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.2 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.2-3.6 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.2-3.7 Job finished with success status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gforcada gforcada deleted the jone-print-urls-1.4.x branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment