Remove jquery-highlightsearchterms and plone_ecmascript layer #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
|
@jensens removing the skin layer and the plone.resources/jquery-highlightsearchterms record works, but how do we remove a single value from the plone.bundles/plone-legacy record? I tried this with no luck:
|
|
ok - found this: https://stackoverflow.com/questions/26874044/how-to-remove-an-element-from-a-list-type-resource-registry-record-using-generic |
…- plone_ecmascript skin layer. See https://github.com/plone/Products.CMFPlone/pull/1963/commits and plone/Products.CMFPlone#1811 plone/Products.CMFPlone#1801 removing records (wip) remove jquery-highlightsearchterms from the plone-legacy bundle c
sunew
force-pushed
the
remove-highlightsearchterms
branch
from
787704c
to
6bab181
Compare
sunew
changed the title
|
All done - for plone 5.2 and 5.1.4 |
This was referenced Sep 6, 2018
…cmascript skin layer for plone 5.1.4
sunew
force-pushed
the
remove-highlightsearchterms
branch
from
bac600b
to
c979968
Compare
sunew
changed the title
|
Still needs to rebuild the legacy bundle. |
|
done |
sunew
changed the title
jensens
approved these changes
Sep 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the jquery-highlightsearchterms resource, and the - now empty - plone_ecmascript skin layer. See https://github.com/plone/Products.CMFPlone/pull/1963/commits and plone/Products.CMFPlone#1811 plone/Products.CMFPlone#1801