Ensured partial searching utility for users in 'Search for users' page

[khanstark]

When clicking on Users tab, 'Search For Users' page shows some ambiguity in search criteria like--
Find users whose email addresses contain. looks like a partial search criteria, but its not. User has to enter qualified valid email in order to proceed.

So I propose to change the default to make it look that way.

[jensens]

Do they? if so: should they or is this a bug?

[khanstark]

Find users whose email addresses contain. to me,as a user, looks like if i enter 'gmail' then all users with pattern 'gmail' in the email addresses would be listed. But thats not what is being done there.Instead it points out Invalid email address error.
This was also pointed out earlier in an issue : plone/Products.CMFPlone#1499

imo this should be an easy fix.

[jensens]

IIRC it should do partial search starting with a string. So a john.doe@gmail.com can be found with john or john.doe but not by searching for doe or gmail.com. This is at least valid for a vanilla Plone. Addons for users from SQL or LDAP or others may behave differently.

[khanstark]

Yeah that would be great but more changes have to be made to achieve this. 👍
what about name criteria then? If a user enters only 'A' then all users with 'A' in their names would be listed?

[thet]

It would be better to do a wildcard search, so that searching for gmail finds also john.doe@gmail.com.
Not sure, how easy that is.

[khanstark]

Removing constraint=checkEmailAddress, from the schema does the job.
Now partial searching is applicable in all three fields. Searching for 'john' in email field will list all users with addresses %john% without giving errors.
There is ofcourse no need to validate email address by any regex since there is no sense of partial searching then.

[jensens]

+1 for removal of that constraint. This is a regression, it used to work in Plone 4 exact like that.

[khanstark]

@jensens what is the problem here ? with the PR i mean..

[gforcada]

@khanstark you can see that at the bottom of this discussion there's a "All checks have failed" and a "Plone Jenkins CI - pull-request-5.1" text with a link on the far right saying "Details". If you click on it (e.g. http://jenkins.plone.org/job/pull-request-5.1/114/ ) you will see all the tests that failed due to this pull request being tested against Plone test suite.

[khanstark]

/cc @gforcada