Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form_tabbing.js deactivated but "pat-autotoc autotabs" not used #104

Open
domruf opened this issue May 20, 2015 · 4 comments
Open

form_tabbing.js deactivated but "pat-autotoc autotabs" not used #104

domruf opened this issue May 20, 2015 · 4 comments

Comments

@domruf
Copy link

domruf commented May 20, 2015

Even though form_tabbing.js gets deactivated when installing p.a.widgets its functionality is not replaced by "pat-autotoc autotabs" AFAIKS.
I think either form_tabbing.js should be kept active or "pat-autotoc autotabs" should be set where ever enableFormTabbing is set.

@frisi
Copy link

frisi commented Aug 24, 2015

just had a look at this, too.
as the page templates do not use the class pat-autotoc but simply enableFormTabbing i think the best and easiest solution is to not add form_tabbing.js to the deprecated bundle.

@fulv
Copy link
Member

fulv commented Sep 16, 2015

@thet: You added this changelog to 1.8.0:

Add the form_tabbing.js and toc.js scripts to the deprecated bundles. They’re made obsolete by mockup-patterns-autotoc. [thet]

Would you please elaborate on how they are made obsolete? Form tabs don't work in Plone 4.3.6 with p.a.w 1.8.0, without undoing the deprecated bundle setting of form_tabbing.js.

@fulv
Copy link
Member

fulv commented Sep 16, 2015

There is a comment on this commit suggesting that plone.app.z3cform should be upgraded. I pinned it to 1.0.1, and it's working so far.

@petschki
Copy link
Member

note: for Plone 4.3.x Archetypes Types you have to use Products.Archetypes >= 1.9.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants