Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template to display related items #111

Merged
merged 5 commits into from Mar 24, 2020
Merged

Conversation

@pbauer
Copy link
Member

pbauer commented Mar 21, 2020

Display items from RelationChoice and RelationList fields instead of showing only uuids.

As discussed in https://community.plone.org/t/widget-view-shows-uid-value/4352/5

Display with this change:
related

Display before:
related_before

…ationList fields instead of only uuids
@mister-roboto

This comment has been minimized.

Copy link

mister-roboto commented Mar 21, 2020

@pbauer thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@pbauer

This comment has been minimized.

Copy link
Member Author

pbauer commented Mar 21, 2020

@jenkins-plone-org please run jobs

plone/app/z3cform/widget.py Outdated Show resolved Hide resolved
plone/app/z3cform/widget.py Outdated Show resolved Hide resolved
pbauer added 2 commits Mar 23, 2020
@pbauer

This comment has been minimized.

Copy link
Member Author

pbauer commented Mar 23, 2020

@jenkins-plone-org please run jobs

@ale-rt
ale-rt approved these changes Mar 23, 2020
Copy link
Member

ale-rt left a comment

LGTM. I added some comments but they are not blockers

@ale-rt ale-rt merged commit 42c7579 into master Mar 24, 2020
5 checks passed
5 checks passed
Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.2 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.2-3.6 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.2-3.7 Job finished with success status
Details
@ale-rt ale-rt deleted the displaytemplate_for_relationfields branch Mar 24, 2020
pbauer added a commit to EUDAT-DPMT/pcp.contenttypes that referenced this pull request Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.