Skip to content
Browse files

Do not raise an error when batch attributes do not exist for whatever…

… reason.
  • Loading branch information...
1 parent a599f34 commit fd717260b761bb20389b909e527407b27f863ee5 Timo Stollenwerk committed May 15, 2012
Showing with 2 additions and 2 deletions.
  1. +2 −2 plone/batching/batchnavigation.pt
View
4 plone/batching/batchnavigation.pt
@@ -5,9 +5,9 @@
>
<div class="listingBar"
i18n:domain="plone"
- tal:condition="batch/multiple_pages">
+ tal:condition="batch/multiple_pages|nothing">
@tomgross
Plone Foundation member
tomgross added a note May 18, 2012

I'm not sure if this is the right way to fix this. Errors should never pass silently. (The Zen of Python, by Tim Peters). A Batch implementing IBatch has these attributes. An error here points to an inconsistent state which will likely make problems on other places too. See https://dev.plone.org/ticket/12875

@tisto
Plone Foundation member
tisto added a note May 18, 2012

You are right. I reverted my commit: 3235554

@tomgross
Plone Foundation member
tomgross added a note May 18, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
<span class="previous"
- tal:condition="batch/has_previous">
+ tal:condition="batch/has_previous|nothing">
<a href=""
tal:attributes="href python:view.make_link(batch.previouspage)">
&laquo;

0 comments on commit fd71726

Please sign in to comment.
Something went wrong with that request. Please try again.