Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break circular reference by moving interface to this package. #30

Merged
merged 2 commits into from Feb 20, 2019

Conversation

Projects
None yet
5 participants
@sallner
Copy link
Contributor

commented Feb 19, 2019

Fixes #29 .

Explicitly declare dependencies which have been there implicitly by depending on Products.CMFPlone.

The interface should be imported in Products.CMFPlone.interfaces after the merge.

Break circular reference by moving interface to this package.
Explicitly declare dependencies which have been there implicitly by depending on Products.CMFPlone.

@sallner sallner requested a review from gforcada Feb 19, 2019

@mister-roboto

This comment was marked as resolved.

Copy link

commented Feb 19, 2019

@sallner thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@sallner

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

@jenkins-plone-org please run jobs

@jensens

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

Is there a PR for Products.CMFPlone already?

@sallner

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

Is there a PR for Products.CMFPlone already?

@jensens No, I actually do not know the procedure to do this, as I would need both branches, here and in plone/Products.CMFPlone So where would be the correct place to do this? My plone contributor skills are not fully developed yet.

Should I leave this PR open till the one on CMFPlone was successful?

@jensens

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

Open two PR's and then log in to Jenkins and fill in both PRs into the fields at https://jenkins.plone.org/job/pull-request-5.2/build?delay=0sec (and for 5.2-3.6 and 5.2-3.7 jobs as above linked in the checks)

@gforcada

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2019

Actually, as this pull request alone can be merged, tests do not break seems, we can merge this one and shortly after create the other in CMFPlone 👍

Or better, prepare the other pull request, and once it has been reviewed (ignore the test failures), let's merge this one and then test the other.

@icemac

icemac approved these changes Feb 20, 2019

Copy link

left a comment

LGTM.

@jensens jensens merged commit 0ef76b4 into master Feb 20, 2019

5 checks passed

Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.2 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.2-3.6 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.2-3.7 Job finished with success status
Details

@jensens jensens deleted the re-29-circular-dep branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.