New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeJS #4

Merged
merged 4 commits into from May 25, 2015

Conversation

Projects
None yet
2 participants
@gforcada
Contributor

gforcada commented May 3, 2015

Trying to run mockup tests on a jenkins node (tried locally with Vagrant) showed that nodeJS current installation is completely broken.

For whichever reason nodeJS refuses to work if the user that tries to use it is different from the one that installed it.

This pull request changes the user that installs nodeJS from root to jenkins (the user that jenkins.plone.org uses on nodes).

Related to plone/jenkins.plone.org#108

gforcada added some commits May 3, 2015

First jenkins user then nodeJS
nodejs needs to be installed by the same user that will run it,
(that's sort of broken right?).

Thus, first jenkins user needs to be created and then nodeJS can
be installed.
Install nodeJS on jenkins user
A globally installed nodeJS (ie either by the package manager or
by another user) makes it unusable when trying to run nodejs on
a jenkins node.

Thus nodeJS needs to be installed by the same user that will later
use it.
Install PhantomJS
This is the browser used by Mockup to test against.

Jenkins nodes need it too to be able to run JavaScript unittests.

@jensens jensens added the pr review label May 20, 2015

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada May 25, 2015

Contributor

Given it is already deployed.... I will merge :) complain later if it breaks something :P

Contributor

gforcada commented May 25, 2015

Given it is already deployed.... I will merge :) complain later if it breaks something :P

gforcada added a commit that referenced this pull request May 25, 2015

@gforcada gforcada merged commit 21709a6 into master May 25, 2015

@gforcada gforcada deleted the nodejs branch May 25, 2015

@gforcada gforcada removed the pr review label May 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment