Permalink
Browse files

Declare dependency on zope.app.component.

  • Loading branch information...
1 parent 247e224 commit 26823f2aecebaa40b2d6506e2d2d221abae5e286 @mauritsvanrees mauritsvanrees committed Aug 18, 2012
Showing with 5 additions and 1 deletion.
  1. +4 −0 CHANGES.txt
  2. +1 −1 setup.py
View
@@ -4,6 +4,10 @@ Changelog
1.6 (unreleased)
----------------
+- Declare dependency on zope.app.component.
+ [maurits]
+
+
1.5 (2012-08-15)
----------------
View
@@ -31,7 +31,7 @@
'Products.GenericSetup',
'Products.MimetypesRegistry',
'Products.PortalTransforms',
- # -*- Extra requirements: -*-
+ 'zope.app.component',
],
extras_require={
'test': ['Products.PloneTestCase'],

2 comments on commit 26823f2

Owner

davisagli replied Aug 20, 2012

In general, we're trying to minimize our dependence on zope.app.* packages, because they are heavily circularly dependent, so when you pull in one all the rest tend to get pulled in even though they aren't actually required. In many cases there is now a zope.* package that can be used instead, and we should be updating Plone code to use those.

I'm guessing this one is for importing getSite? That should be from zope.component.hooks now (with a fallback to zope.app.component if zope.component.hooks isn't present, for backwards-compatibility).

I had problems getting a 4.2 instance to start because some zope.app packages were missing. So finally I went through the checkouts I had and added zope.app dependencies to packages that seemed to need them, with help of z3c.dependencychecker. I see that in this case zope.app.component was only used as compatibility import in case an import from zope.component did not work. So I will undo this change.

Adding the dependencies in Products.CMFPlone for the 4.2 series, as you found later, like in the Plone egg, turned out to be a better idea.

Thanks for keeping an eye on code quality!

Please sign in to comment.