New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to reflect changes in PortalTransforms #25

Merged
merged 4 commits into from Jul 28, 2017

Conversation

Projects
None yet
4 participants
@MrTango
Contributor

MrTango commented Jul 7, 2017

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Jul 13, 2017

Contributor

@MrTango do you have any explanation as to why the tests pass in 5.0 pull request job if both portaltransforms and cmfplone changes are only in 5.1?

Contributor

gforcada commented Jul 13, 2017

@MrTango do you have any explanation as to why the tests pass in 5.0 pull request job if both portaltransforms and cmfplone changes are only in 5.1?

@MrTango

This comment has been minimized.

Show comment
Hide comment
@MrTango

MrTango Jul 28, 2017

Contributor

@gforcada the changes as well as this PR plone/Products.CMFPlone#2098 can be backported to 5.0. I gues it's not that hard, but I didn't had the time at the sprint and I'm currently very bussy.
So if some one is interested to port these back to 5.0.x that would be great.

Contributor

MrTango commented Jul 28, 2017

@gforcada the changes as well as this PR plone/Products.CMFPlone#2098 can be backported to 5.0. I gues it's not that hard, but I didn't had the time at the sprint and I'm currently very bussy.
So if some one is interested to port these back to 5.0.x that would be great.

@agitator agitator merged commit 503be94 into master Jul 28, 2017

4 checks passed

Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.0 Job finished with success status
Details
Plone Jenkins CI - pull-request-5.1 Job finished with success status
Details

@agitator agitator deleted the midsummersprint_fix_transforms branch Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment