New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@search endpoint path.query does not work with VHM #186

Closed
sneridagh opened this Issue Jan 19, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@sneridagh
Copy link
Member

sneridagh commented Jan 19, 2017

Given a site is behind a VHM config using a root server name, so the instance name is hidden, when you request

@search?path.query=/

You don't get nothing, and if you use the name of the instance:

@search?path.query=/Plone

it works fine.

For consistency I would match the VHM configuration, so the query root matches the root of the server. Thus, the users don't have to know the instance name behind a server deployment.

/cc @tisto

@lukasgraf

This comment has been minimized.

Copy link
Member

lukasgraf commented Jan 19, 2017

@sneridagh I agree with the desired behavior you described. Hopefully I'll get around to a fix for this soon.

@lukasgraf lukasgraf self-assigned this Jan 19, 2017

@sneridagh

This comment has been minimized.

Copy link
Member

sneridagh commented Jan 19, 2017

@tisto tisto added the 01 type: bug label Feb 27, 2017

@tisto tisto referenced this issue Feb 27, 2017

Closed

Beethoven Sprint Planning #214

18 of 56 tasks complete

sneridagh added a commit that referenced this issue Mar 3, 2017

lukasgraf added a commit that referenced this issue Mar 4, 2017

Add missing id to the Plone site serialization, related to issue #186 (
…#229)

* Add missing id to the Plone site serialization, related to issue #186

* Add changelog

* Add the changes to the auto generated data files for docs.

* Add missing generated _json/siteroot.json

witsch added a commit to witsch/plone.restapi that referenced this issue Mar 5, 2017

Merge remote-tracking branch 'plone/master' into 'coverage-fixes'
* plone/master:
  @search endpoint: Also prefill path query dict with context path.
  Overhaul JSON schema generation for @types endpoint:
  Add missing id to the Plone site serialization, related to issue plone#186 (plone#229)
  Revert "Revert "Back to development: 1.0a10""
  Added API conventions.
  Revert "Back to development: 1.0a10"
  Revert "Preparing release 1.0a10"
  Preparing release 1.0a10
  Back to development: 1.0a10
  Preparing release 1.0a9
@sunew

This comment has been minimized.

Copy link
Contributor

sunew commented Sep 5, 2018

@sneridagh and @lukasgraf this was fixed by csengers PR (and I have fixed restricting to multiple paths behind vhm in #615 )

I close this issue :)

@sunew sunew closed this Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment