Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order users by fullname. #1223

Merged
merged 1 commit into from Sep 13, 2021
Merged

Order users by fullname. #1223

merged 1 commit into from Sep 13, 2021

Conversation

ericof
Copy link
Sponsor Member

@ericof ericof commented Sep 13, 2021

Fixes #1222

@ericof ericof self-assigned this Sep 13, 2021
@mister-roboto
Copy link

@ericof thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ericof
Copy link
Sponsor Member Author

ericof commented Sep 13, 2021

@jenkins-plone-org please run jobs

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So searchUsers in acl_users does not do it by default? :/

@ericof ericof merged commit 3956dde into master Sep 13, 2021
@ericof ericof deleted the users-ordering-fix branch September 13, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@users endpoint should return users ordered by fullname
3 participants