Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose widgets tagged values via @types endpoint #516

Merged
merged 12 commits into from Apr 17, 2018

Conversation

Projects
None yet
3 participants
@jaroel
Copy link
Member

jaroel commented Mar 13, 2018

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 13, 2018

Coverage Status

Coverage decreased (-0.008%) to 96.514% when pulling 58f230b on types_vocab into ada28b9 on master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 13, 2018

Coverage Status

Coverage decreased (-0.008%) to 96.514% when pulling 58f230b on types_vocab into ada28b9 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 13, 2018

Coverage Status

Coverage increased (+0.003%) to 96.399% when pulling 079e06a on types_vocab into bfd78ce on master.

@tisto

This comment has been minimized.

Copy link
Member

tisto commented Mar 13, 2018

tisto and others added some commits Mar 13, 2018

Just test the get_jsonschema_for_fti function, as it is already calle…
…d in @types endpoint. This will works for all Plone versions.

@jaroel jaroel changed the title Expose widgets tagged values via @types endpoint WIP Expose widgets tagged values via @types endpoint Mar 14, 2018

@jaroel jaroel changed the title WIP Expose widgets tagged values via @types endpoint WIP: Expose widgets tagged values via @types endpoint Mar 14, 2018

jaroel and others added some commits Mar 14, 2018

@tisto

This comment has been minimized.

Copy link
Member

tisto commented Mar 17, 2018

@jaroel this is still WIP, correct?

@tisto

This comment has been minimized.

Copy link
Member

tisto commented Mar 20, 2018

@jaroel just a quick check. This is not a breaking change, correct? We just add the tagged values to the response. I am just asking because I plan to do a 2.0.0 release soon and I am wondering if we have to include this in the release or not (if it is a breaking change, we have to).

@jaroel

This comment has been minimized.

Copy link
Member Author

jaroel commented Mar 20, 2018

@tisto This only adds stuff, so unless someone is using type definitions for the json, this is not a breaking change.

This renders the keywords vocabulary in the schema, alike choice fields. Rob and I think that shouldn't be that much of a problem and allows us to have an autocomplete widget for keywords.

@jaroel jaroel changed the title WIP: Expose widgets tagged values via @types endpoint Expose widgets tagged values via @types endpoint Mar 20, 2018

@jaroel

This comment has been minimized.

Copy link
Member Author

jaroel commented Mar 20, 2018

I'll check the Plone 4.x test failures.

@tisto tisto added this to the 2.0.0 milestone Mar 26, 2018

tisto added some commits Apr 17, 2018

@tisto tisto merged commit e687579 into master Apr 17, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tisto tisto deleted the types_vocab branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.