New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest plone releases (4.3.17, 5.1.2); remove old buildout … #537

Merged
merged 1 commit into from Jun 23, 2018

Conversation

Projects
None yet
3 participants
@sunew
Contributor

sunew commented Jun 22, 2018

…bootstrap files (we use pip install -r requirements.txt); split versions overrides for each plone version

@sunew sunew requested a review from tisto Jun 22, 2018

@coveralls

This comment has been minimized.

coveralls commented Jun 22, 2018

Coverage Status

Coverage increased (+0.02%) to 96.455% when pulling fb1a00c on update-and-cleanup-buildout into 5afe77b on master.

@tisto

This comment has been minimized.

Member

tisto commented Jun 22, 2018

@sunew LGTM. Though, I am not sure if moving the package pinning to the individual buildout files is a good idea. This way we have to maintain multiple version pinnings. So far we got away with a single versions.cfg file. Can you elaborate why you did this?

@sunew

This comment has been minimized.

Contributor

sunew commented Jun 22, 2018

@tisto there were some 'upgrades' for the RC that would now be 'downgrades' for 5.1.2.
While at the same time we still need those pinnings for plone 4 and 5.0.
So we need to split the versions for 5.1 and the older releases.
Of course some are the same, such as Sphinx and other tools - I could move them to a shared versions.cfg
I don't know - it's either the plague or cholera ;)

@sunew

This comment has been minimized.

Contributor

sunew commented Jun 22, 2018

@tisto fixed. Now we have a common versions.cfg, and a pre-51 versions for the upgrades for plone 5.0 and 4.

@sunew

This comment has been minimized.

Contributor

sunew commented Jun 22, 2018

@tisto I suggest going with this as it is now - the old pins are needed to upgrade to tools for 5.0 and 4, (to keep it equivalent to the old buildout and test runs).
While we certainly don't want to downgrade 5.1 versions, which would happen if we keep the versions as is.
And its about time we move default to 5.1

@sunew sunew changed the title from Update to latest plone releases (4.3.17, 5.1.2); remove old buildout … to WIP: Update to latest plone releases (4.3.17, 5.1.2); remove old buildout … Jun 23, 2018

Update to latest plone releases (4.3.17, 5.1.2); remove old buildout …
…bootstrap files (we use pip install -r requirements.txt); split versions overrides for each plone version
@sunew

This comment has been minimized.

Contributor

sunew commented Jun 23, 2018

@tisto changed to be more in more in line with your feedback:)

@sunew sunew changed the title from WIP: Update to latest plone releases (4.3.17, 5.1.2); remove old buildout … to Update to latest plone releases (4.3.17, 5.1.2); remove old buildout … Jun 23, 2018

@tisto

tisto approved these changes Jun 23, 2018

LGTM. Ready to merge as soon as Travis is green.

@sunew sunew merged commit 88a7f61 into master Jun 23, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.455%
Details

@sunew sunew deleted the update-and-cleanup-buildout branch Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment