Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate the fti title in @types endpoint #540

Merged
merged 3 commits into from Jun 23, 2018

Conversation

Projects
None yet
4 participants
@erral
Copy link
Member

erral commented Jun 22, 2018

This fixes #337

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 22, 2018

Coverage Status

Coverage increased (+0.0008%) to 96.42% when pulling e02713e on issue-337-translated-titles-in-types into fb94ad7 on master.

@tisto

This comment has been minimized.

Copy link
Member

tisto commented Jun 22, 2018

@erral LGTM. Please add a changelog entry.

@erral erral force-pushed the issue-337-translated-titles-in-types branch from 2565a97 to fdd13fc Jun 22, 2018

@erral

This comment has been minimized.

Copy link
Member Author

erral commented Jun 22, 2018

I have a test for it, although I don't know if it's necessary, as far as we are already doing this translate stuff in some other places (like in the @types/Folder call) without the test: https://github.com/plone/plone.restapi/blob/master/src/plone/restapi/types/utils.py#L189

@lukasgraf

This comment has been minimized.

Copy link
Member

lukasgraf commented Jun 22, 2018

I've cleaned up setting the available and supported languages, as well as enabling request language negotiation for my work on the @roles titles in a way where we can apply it for all our tests, for Plone 4 as well as Plone 5.

So you should be able to easily base your test on that once I've pushed.

@erral erral force-pushed the issue-337-translated-titles-in-types branch from fdd13fc to e02713e Jun 23, 2018

@erral erral force-pushed the issue-337-translated-titles-in-types branch 2 times, most recently from 4fefe47 to fe4dd90 Jun 23, 2018

@erral

This comment has been minimized.

Copy link
Member Author

erral commented Jun 23, 2018

#545 needs to be merged before this one.

@erral erral force-pushed the issue-337-translated-titles-in-types branch from fe4dd90 to 759a171 Jun 23, 2018

@lukasgraf
Copy link
Member

lukasgraf left a comment

Just one detail, looks good to me otherwise! 👍 🎉


import transaction
import unittest

PLONE_VERSION = parse_version(api.env.plone_version())

This comment has been minimized.

@lukasgraf

lukasgraf Jun 23, 2018

Member

This is unused I think.

This comment has been minimized.

@erral

erral Jun 23, 2018

Author Member

Yeah, traces of the code that I had before your changes :)

@erral erral force-pushed the issue-337-translated-titles-in-types branch from 759a171 to 47255db Jun 23, 2018

@erral erral changed the title [WIP] Translate the fti title in @types endpoint Translate the fti title in @types endpoint Jun 23, 2018

@tisto tisto merged commit 2fd577b into master Jun 23, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on master at 96.435%
Details

@tisto tisto deleted the issue-337-translated-titles-in-types branch Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.