New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate workflow history titles #541

Merged
merged 5 commits into from Jun 24, 2018

Conversation

Projects
None yet
4 participants
@erral
Member

erral commented Jun 22, 2018

⚠️ #545 needs to be merged before this one. ⚠️


Like in #337 but with transition names, action titles and state titles in @worfklow endpoint

@erral

This comment has been minimized.

Member

erral commented Jun 23, 2018

#545 needs to be merged before this one.

@lukasgraf

Just one minor details, otherwise looks good to me! 👍 🎉

self.portal_url = self.portal.absolute_url()
setRoles(self.portal, TEST_USER_ID, ['Manager'])
set_available_languages()

This comment has been minimized.

@lukasgraf

lukasgraf Jun 23, 2018

Member

These three shouldn't be necessary any more since this is now done in the PloneRestApiDXLayer

erral and others added some commits Jun 22, 2018

@coveralls

This comment has been minimized.

coveralls commented Jun 23, 2018

Coverage Status

Coverage decreased (-0.3%) to 96.188% when pulling 15ecf4f on translate-workflow-history into 2fd577b on master.

@erral erral changed the title from [WIP] Translate workflow history titles to Translate workflow history titles Jun 23, 2018

@tisto tisto self-requested a review Jun 24, 2018

@tisto

tisto approved these changes Jun 24, 2018

@tisto tisto merged commit c92af77 into master Jun 24, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 96.461%
Details

@tisto tisto deleted the translate-workflow-history branch Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment