Translate workflow history titles #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erral
force-pushed
the
translate-workflow-history
branch
2 times, most recently
from
f642fdd to
80a90c4
Compare
Member
Author
|
#545 needs to be merged before this one. |
lukasgraf
requested changes
Jun 23, 2018
Member
lukasgraf
left a comment
lukasgraf
left a comment
There was a problem hiding this comment.
Just one minor details, otherwise looks good to me! 👍 🎉
| self.portal_url = self.portal.absolute_url() | ||
| setRoles(self.portal, TEST_USER_ID, ['Manager']) | ||
|
|
||
| set_available_languages() |
Member
There was a problem hiding this comment.
These three shouldn't be necessary any more since this is now done in the PloneRestApiDXLayer
erral
force-pushed
the
translate-workflow-history
branch
from
80a90c4 to
6031505
Compare
erral
force-pushed
the
translate-workflow-history
branch
from
6031505 to
d94e6a0
Compare
erral
changed the title
tisto
approved these changes
Jun 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in #337 but with transition names, action titles and state titles in
@worfklowendpoint