Include translated role title in @roles GET
#545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so we can use the Accept-Language header to request translated pieces of content in different languages.
This returns the translated role name (as displayed in the "Users and Groups" control panel) as the title property in the output of the @roles endpoint. Note that the sharing view uses a different set of translations for the same role ID.
erral
approved these changes
Jun 23, 2018
Member
erral
left a comment
erral
left a comment
There was a problem hiding this comment.
Nice! Specially the test-setup changes are much easier now.
This was referenced Jun 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include translated role title in
@rolesGET:This returns the translated role name (as displayed in the "Users and Groups" control panel) as the title property in the output of the
@rolesendpoint.Also includes some groundwork in setting up languages (available & supported, request negotiation) consistently during tests.
/cc @erral
Note that the sharing view uses a different set of translations for the same role ID. At first, my intent was to use the same serialization of roles (plus their titles) for both the
@rolesendpoint as well as well as the available roles in the@sharingendpoint.But since Plone itself uses different translations for roles in two places, I would suggest to just handle them seperately in these endpoints as well:
Examples for how role titles are currently translated in Plone 5:
"Users and Groups" Control Panel
Sharing Page