New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create image URLs using the cache optimized URLs #553

Merged
merged 7 commits into from Jun 26, 2018

Conversation

Projects
None yet
6 participants
@erral
Member

erral commented Jun 23, 2018

This fixes #494

@erral

This comment has been minimized.

Member

erral commented Jun 23, 2018

I had to patch the uuid4 method, and achieved that using mock as dependency, I don't know if that's good practice here... I haven't seen something similar in the codebase.

@coveralls

This comment has been minimized.

coveralls commented Jun 23, 2018

Coverage Status

Coverage increased (+0.01%) to 96.418% when pulling e00b2ed on issue-494-image-scales into d2a4221 on master.

@erral erral changed the title from [WIP] Create image URLs using the cache optimized URLs to Create image URLs using the cache optimized URLs Jun 24, 2018

@erral

This comment has been minimized.

Member

erral commented Jun 24, 2018

I'm not pretty sure if the way I used to create the scale URLs is fully optimal. I called the @@images view and used it...

@davisagli

This comment has been minimized.

Member

davisagli commented Jun 24, 2018

@erral it looks right to me

@tisto tisto requested review from jensens, davisagli and lukasgraf Jun 24, 2018

@tisto tisto added this to the 3.0.0 milestone Jun 24, 2018

@tisto tisto self-requested a review Jun 24, 2018

@tisto

tisto approved these changes Jun 24, 2018

@tisto

This comment has been minimized.

Member

tisto commented Jun 25, 2018

@erral would you mind adding a short note to our upgrade guide? If you don't have time for it I can also take care of it tomorrow...

tisto and others added some commits Jun 25, 2018

@erral

This comment has been minimized.

Member

erral commented Jun 26, 2018

Done.

@tisto

This comment has been minimized.

Member

tisto commented Jun 26, 2018

@erral the real implementation returns different URLs with different UUIDs for every single scale as described here:

https://github.com/plone/plone.restapi/pull/553/files#diff-772cee6f1ad591450b99fdde08976749

right?

The auto-generated response just has the same URL/UUID for all image scales just because of the mock, is that correct?

@erral

This comment has been minimized.

Member

erral commented Jun 26, 2018

Yes, that's right.

@erral

This comment has been minimized.

Member

erral commented Jun 26, 2018

@tisto tisto merged commit 1255707 into master Jun 26, 2018

4 checks passed

code-quality/landscape Landscape has completed the code quality check
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.06%) to 96.087%
Details

@tisto tisto deleted the issue-494-image-scales branch Jun 26, 2018

@buchi

This comment has been minimized.

Member

buchi commented on CHANGES.rst in e00b2ed Jun 26, 2018

@tisto this was already in release 2.2.0. The changelog seem to have gotten shuffled by automatic merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment