Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix tests on 52 #562
Conversation
sunew
added some commits
Jun 24, 2018
| @@ -22,7 +22,7 @@ def setUp(self): | ||
| def test_roles_endpoint_lists_roles(self): | ||
| response = self.api_session.get('/@roles') | ||
| self.assertEqual([ | ||
| self.assertItemsEqual([ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sunew
Jun 24, 2018
Contributor
The list order changed in plone 5.2
We should use assertItemsEqual when comparing lists.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Jun 24, 2018
•
tisto
merged commit 8fc8060
into
master
Jun 24, 2018
4 checks passed
tisto
deleted the
fix-test-on-52
branch
Jun 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sunew commentedJun 24, 2018
No description provided.