Skip to content

Fix tests on 52 #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2018
Merged

Fix tests on 52 #562

merged 2 commits into from
Jun 24, 2018

Conversation

sunew
Copy link
Contributor

@sunew sunew commented Jun 24, 2018

No description provided.

@@ -22,7 +22,7 @@ def setUp(self):
def test_roles_endpoint_lists_roles(self):
response = self.api_session.get('/@roles')

self.assertEqual([
self.assertItemsEqual([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunew can you elaborate why "assertEqual" stopped working in Plone 5.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list order changed in plone 5.2
We should use assertItemsEqual when comparing lists.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thank you @sunew!

@coveralls
Copy link

coveralls commented Jun 24, 2018

Coverage Status

Coverage decreased (-0.3%) to 96.208% when pulling 85602a5 on fix-test-on-52 into c16c6f2 on master.

@tisto tisto merged commit 8fc8060 into master Jun 24, 2018
@tisto tisto deleted the fix-test-on-52 branch June 24, 2018 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants