New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on 52 #562

Merged
merged 2 commits into from Jun 24, 2018

Conversation

Projects
None yet
3 participants
@sunew
Contributor

sunew commented Jun 24, 2018

No description provided.

@@ -22,7 +22,7 @@ def setUp(self):
def test_roles_endpoint_lists_roles(self):
response = self.api_session.get('/@roles')
self.assertEqual([
self.assertItemsEqual([

This comment has been minimized.

@tisto

tisto Jun 24, 2018

Member

@sunew can you elaborate why "assertEqual" stopped working in Plone 5.2?

This comment has been minimized.

@sunew

sunew Jun 24, 2018

Contributor

The list order changed in plone 5.2
We should use assertItemsEqual when comparing lists.

This comment has been minimized.

@tisto

tisto Jun 24, 2018

Member

Cool. Thank you @sunew!

@coveralls

This comment has been minimized.

coveralls commented Jun 24, 2018

Coverage Status

Coverage decreased (-0.3%) to 96.208% when pulling 85602a5 on fix-test-on-52 into c16c6f2 on master.

@tisto tisto merged commit 8fc8060 into master Jun 24, 2018

4 checks passed

code-quality/landscape Landscape has completed the code quality check
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.3%) to 96.208%
Details

@tisto tisto deleted the fix-test-on-52 branch Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment