New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Portlets, basis for discussion. Only GET #563

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@sunew
Contributor

sunew commented Jun 24, 2018

No description provided.

sunew added some commits Jun 22, 2018

@coveralls

This comment has been minimized.

coveralls commented Jun 24, 2018

Coverage Status

Coverage decreased (-0.3%) to 95.879% when pulling e4136ae on portlets into 61af906 on master.

@tisto tisto modified the milestones: 3.0.0, 3.x.x Jun 24, 2018

@tisto tisto changed the title from WIP: Portlets, basis for discussion. Only GET to [WIP] Portlets, basis for discussion. Only GET Jun 24, 2018

@tisto

This comment has been minimized.

Member

tisto commented Jun 29, 2018

@sunew is this still WIP or ready for review?

@sunew

This comment has been minimized.

Contributor

sunew commented Jun 29, 2018

@tisto Its more a basis for discussion about what we want to do with portlets.
I will write up a short list of questions to consider.
Dont merge, there is no tests yet, etc.

@tisto

This comment has been minimized.

Member

tisto commented Jul 3, 2018

@sunew as said, I wouldn't mind adding portlets to plone.restapi. Though, this seems like a lot of work. I think the portlets endpoint should definitely be an expandable, so we can include portlets in the reponse. What's your plan with this? Finishing the GET stuff first and then merge or work on a big bang PR with everything included?

@sunew

This comment has been minimized.

Contributor

sunew commented Jul 3, 2018

@tisto
I think the most difficult thing is solved (that is, getting the actual schema to serialize for an assignment).

GET is working as a proof of concept.

My plans are:

  1. make it possible to GET individual portlets by assignment id (very easy)
  2. make the portmanager expandable (easy)
  3. differentiate types of portlets on portletmanager GET (context portlets, dashboard, etc.)
  4. Get possible kinds of portlets to add
  5. endpoint for adding a portlet.
  6. endpoint for patch / update / delete

4-6 I have not yet worked on, but it should not be too hard.
Maybe we begin with 1-3 and then merge (incl .tests) ?

I would love a review of the docs - I can update them with the above during one of the next few days, and then ask for your feedback?

@tisto

This comment has been minimized.

Member

tisto commented Jul 3, 2018

@sunew sounds like a sensible plan! I am happy to review the docs. Just let me know when you are done with your update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment