Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effective date not set #761

Merged
merged 3 commits into from Jun 21, 2019
Merged

Effective date not set #761

merged 3 commits into from Jun 21, 2019

Conversation

wkbkhard
Copy link
Member

@wkbkhard wkbkhard commented Jun 21, 2019

@wkbkhard wkbkhard requested a review from buchi Jun 21, 2019
@mister-roboto
Copy link

@mister-roboto mister-roboto commented Jun 21, 2019

@wkbkhard thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

buchi
buchi approved these changes Jun 21, 2019
Copy link
Member

@buchi buchi left a comment

👍 LGTM

@@ -16,6 +16,7 @@
from zope.interface import implementer
from zope.publisher.interfaces import IPublishTraverse
from zope.publisher.interfaces import NotFound
from DateTime import DateTime
Copy link
Member

@buchi buchi Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordering of imports does not conform to the Plone style guide (https://docs.plone.org/develop/styleguide/python.html#grouping-and-sorting). But that was already the case before that change.

Copy link
Member

@tisto tisto Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into this...

@tisto
Copy link
Member

@tisto tisto commented Jun 21, 2019

@jenkins-plone-org please run jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants