Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effective date not set #761

Merged
merged 3 commits into from Jun 21, 2019

Conversation

@wkbkhard
Copy link
Contributor

commented Jun 21, 2019

@wkbkhard wkbkhard requested a review from buchi Jun 21, 2019
@mister-roboto

This comment has been minimized.

Copy link

commented Jun 21, 2019

@wkbkhard thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@buchi
buchi approved these changes Jun 21, 2019
Copy link
Member

left a comment

👍 LGTM

@@ -16,6 +16,7 @@
from zope.interface import implementer
from zope.publisher.interfaces import IPublishTraverse
from zope.publisher.interfaces import NotFound
from DateTime import DateTime

This comment has been minimized.

Copy link
@buchi

buchi Jun 21, 2019

Member

Ordering of imports does not conform to the Plone style guide (https://docs.plone.org/develop/styleguide/python.html#grouping-and-sorting). But that was already the case before that change.

This comment has been minimized.

Copy link
@tisto

tisto Jun 21, 2019

Member

I will look into this...

@tisto

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

@jenkins-plone-org please run jobs.

@tisto tisto merged commit 8177080 into master Jun 21, 2019
5 of 8 checks passed
5 of 8 checks passed
Plone Jenkins CI - pull-request-5.2 Please run the job, click here --->
Details
Plone Jenkins CI - pull-request-5.2-3.6 Please run the job, click here --->
Details
Plone Jenkins CI - pull-request-5.2-3.7 Please run the job, click here --->
Details
Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on effectiveDateNotSet at 96.243%
Details
@tisto tisto deleted the effectiveDateNotSet branch Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.