move hero to content, refs https://github.com/plone/Products.CMFPlone… #83
Conversation
| <!-- move hero to top --> | ||
| <replace css:theme-children="#hero .gigantic" css:content-children=".hero"/> | ||
| <drop css:theme="#hero" css:if-not-content=".hero" /> | ||
| <drop css:content=".hero" /> |
There was a problem hiding this comment.
Sure, this works? Regarding http://docs.diazo.org/en/latest/basic.html#order-of-rule-execution <drop> rules are executed before <replace> rules. Looks to me, wether you'd have to remove the <drop> rule or add a method="raw" to your <replace> rule.
In either case you'd need to remove the method="raw" attribute of the replace-rule which copies the main content (also discussed here: https://community.plone.org/t/adding-html-snippets-with-diazo/1554/15 and #85 )
Sorry, didn't try out your pull, so this might be wrong...
There was a problem hiding this comment.
Works for me on a fresh coredev... I think the key is that I'm extracting the children - I guess that takes precedence.
There was a problem hiding this comment.
Perfect!
But then the Diazo docs are wrong... Maybe something has changed at some point...
fixes #974 requires plone/plonetheme.barceloneta#83
|
@gyst unfortunately also this branch is in conflict and needs a rebase. I'll merge if both are in sync. |
gyst
force-pushed
the
hero_in_content
branch
from
d8ffcc4
to
0b849a1
Compare
|
Rebased and te-tested OK. Ready for merge. |
move hero to content, refs https://github.com/plone/Products.CMFPlone…
Branch: refs/heads/master Date: 2016-02-22T15:36:58+01:00 Author: Guido A.J. Stevens (gyst) <guido.stevens@cosent.nl> Commit: plone/Products.CMFPlone@5ced858 move hero to content fixes plone/Products.CMFPlone#974 requires plone/plonetheme.barceloneta#83 Files changed: M CHANGES.rst M Products/CMFPlone/browser/configure.zcml M Products/CMFPlone/browser/templates/plone-frontpage.pt D Products/CMFPlone/browser/templates/hero.pt Repository: Products.CMFPlone Branch: refs/heads/master Date: 2016-02-22T17:08:28+01:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/Products.CMFPlone@a74391d Merge pull request #1374 from plone/hero_in_content move hero to content Files changed: M CHANGES.rst M Products/CMFPlone/browser/configure.zcml M Products/CMFPlone/browser/templates/plone-frontpage.pt D Products/CMFPlone/browser/templates/hero.pt
Fixes plone/Products.CMFPlone#974
Only together with plone/Products.CMFPlone#1374