New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Router 4 #9

Closed
robgietema opened this Issue Apr 20, 2017 · 2 comments

Comments

Projects
3 participants
@robgietema
Member

robgietema commented Apr 20, 2017

Waiting on compatibly with redux-connect (makeomatic/redux-connect#107).

@nileshgulia1

This comment has been minimized.

Member

nileshgulia1 commented Sep 14, 2018

Here is a list of the things we’ll need to do to migrate:

  • Change react-router to react-router-dom
  • Use Specialized Router Components
  • Add <Switch> to List of Routes
  • Add exact to Routes
  • Replace Nested Routes By Routes In Child Components
  • Replace <IndexRoute> by a regular <Route>
  • Replace the params props by match.params
  • Parse The Query String ourselves.
  • Replace onEnter with componentWillMount? Don't know about it though.
  • Redo Redux Integration
    -cc @tisto @robgietema
@robgietema

This comment has been minimized.

Member

robgietema commented Nov 9, 2018

Fixed in master.

@robgietema robgietema closed this Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment